fix: allow nullables properties in SubscriptionPurchase (#223)

Co-authored-by: Dhemy <[email protected]>

Author: panchograblev

src/Domain/Purchase/Entity/SubscriptionPurchase.php

@@ -29,8 +29,8 @@ public function __construct(
         public string $regionCode,
         public SubscriptionState $subscriptionState,
         public AcknowledgementState $acknowledgementState,
-        public ExternalAccountIdentifiers $externalAccountIdentifiers,
-        public SubscribeWithGoogleInfo $subscribeWithGoogleInfo,
+        public ?ExternalAccountIdentifiers $externalAccountIdentifiers = null,
+        public ?SubscribeWithGoogleInfo $subscribeWithGoogleInfo = null,
         public array $lineItems = [],
         public ?GooglePlay\Time $startTime = null,
         public ?string $linkedPurchaseToken = null,

src/Domain/Purchase/Subscription/OfferDetails.php

@@ -12,11 +12,11 @@
 final readonly class OfferDetails
 {
     /**
-     * @param string[] $offerTags
+     * @param string[]|null $offerTags
      */
     public function __construct(
-        public array $offerTags,
         public string $basePlanId,
+        public ?array $offerTags = null,
         public ?string $offerId = null,
     ) {
     }

tests/Domain/Purchase/Entity/SubscriptionPurchaseTest.php

@@ -90,4 +90,30 @@ public function instantiation(): void
             $actual->subscribeWithGoogleInfo
         );
     }
+
+    /** @test */
+    public function instantiation_with_required_fields(): void
+    {
+        $data = [
+            'kind' => 'androidpublisher#subscriptionPurchaseV2',
+            'regionCode' => $this->faker->countryCode(),
+            'subscriptionState' => $this->randomEnumValue(SubscriptionState::class),
+            'acknowledgementState' => $this->randomEnumValue(enumClass: AcknowledgementState::class),
+        ];
+
+        $actual = $this->normalizer->normalize($data, SubscriptionPurchase::class);
+
+        $this->assertSame($data['kind'], $actual->kind);
+        $this->assertSame($data['regionCode'], $actual->regionCode);
+        $this->assertSame($data['subscriptionState'], $actual->subscriptionState->value);
+        $this->assertSame($data['acknowledgementState'], $actual->acknowledgementState->value);
+        $this->assertNull($actual->externalAccountIdentifiers);
+        $this->assertNull($actual->subscribeWithGoogleInfo);
+        $this->assertEmpty($actual->lineItems);
+        $this->assertNull($actual->startTime);
+        $this->assertNull($actual->linkedPurchaseToken);
+        $this->assertNull($actual->pausedStateContext);
+        $this->assertNull($actual->canceledStateContext);
+        $this->assertNull($actual->testPurchase);
+    }
 }

tests/Domain/Purchase/Subscription/OfferDetailsTest.php

@@ -28,4 +28,17 @@ public function instantiation(): void
         $this->assertSame($basePlanId, $actual->basePlanId);
         $this->assertSame($offerId, $actual->offerId);
     }
+
+    /** @test */
+    public function instantiation_with_required_fields(): void
+    {
+        $data = ['basePlanId' => $this->faker->word()];
+
+        $actual = $this->normalizer->normalize($data, OfferDetails::class);
+
+        $this->assertInstanceOf(OfferDetails::class, $actual);
+        $this->assertSame($data['basePlanId'], $actual->basePlanId);
+        $this->assertNull($actual->offerTags);
+        $this->assertNull($actual->offerId);
+    }
 }