[1.x] Console commands improvements (#434)

Author: imdhemy

.gitignore

@@ -3,6 +3,8 @@ vendor/
 .idea/
 
 .phpunit.cache
+.phpunit.result.cache
+
 .php_cs.cache
 .php-cs-fixer.cache
 .psalm-cache

.php-cs-fixer.dist.php

@@ -1,9 +1,10 @@
 <?php
+
 declare(strict_types=1);
 
 $finder = PhpCsFixer\Finder::create()
     ->in(__DIR__)
-    ->exclude('vendor');
+    ->exclude(['vendor']);
 
 $ruleSet = [
     '@Symfony' => true,

composer.json

@@ -25,10 +25,11 @@
     "laravel/framework": ">=8.0"
   },
   "require-dev": {
-    "roave/security-advisories": "dev-latest",
     "friendsofphp/php-cs-fixer": "^3.14",
     "orchestra/testbench": "^6.24",
     "psalm/plugin-laravel": "^2.0",
+    "psalm/plugin-phpunit": "^0.19.0",
+    "roave/security-advisories": "dev-latest",
     "vimeo/psalm": "^5.11"
   },
   "autoload": {

composer.lock

@@ -18,5 +18,6 @@
 
     <plugins>
         <pluginClass class="Psalm\LaravelPlugin\Plugin"/>
+        <pluginClass class="Psalm\PhpUnitPlugin\Plugin"/>
     </plugins>
 </psalm>

psalm.xml

@@ -11,13 +11,9 @@
 /**
  * This command is used to publish LIAP configuration file.
  */
-class LiapConfigPublishCommand extends Command
+final class LiapConfigPublishCommand extends Command
 {
-    public const MESSAGE_ALREADY_INSTALLED = 'liap.php is already published.';
-    public const MESSAGE_SUCCESS = 'liap.php published successfully';
-
     protected $signature = 'liap:config:publish {--f|force}';
-
     protected $description = 'Publishes the LIAP configuration file.';
 
     public function handle(): int
@@ -26,16 +22,13 @@ public function handle(): int
             return $this->publishConfig(true);
         }
 
-        if ($this->isInstalled()) {
+        if ($this->isPublished()) {
             return $this->publishFailed();
         }
 
         return $this->publishConfig();
     }
 
-    /**
-     * Checks if the command should force publish the configs.
-     */
     private function shouldForce(): bool
     {
         return (bool)$this->option('force');
@@ -52,20 +45,17 @@ private function publishConfig(bool $force = false): int
             $params['--force'] = true;
         }
 
-        $result = $this->call('vendor:publish', $params);
-        $this->info(self::MESSAGE_SUCCESS);
-
-        return $result;
+        return $this->call('vendor:publish', $params);
     }
 
-    private function isInstalled(): bool
+    private function isPublished(): bool
     {
         return File::exists(config_path(LiapServiceProvider::CONFIG_KEY.'.php'));
     }
 
     private function publishFailed(): int
     {
-        $this->error(self::MESSAGE_ALREADY_INSTALLED);
+        $this->error('liap.php is already published.');
 
         return self::FAILURE;
     }