Skip to content

Commit 306ffd0

Browse files
authored
Merge pull request #222 from cabanier/canvas
fix offscreen canvas sample
2 parents 640a845 + b5638ff commit 306ffd0

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

js/render/nodes/gltf2.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ export class Gltf2Node extends Node {
5555
this._resolver = null;
5656
this._rejecter = null;
5757
}).catch((err) => {
58-
this._rejecter(err);
58+
if (this._rejecter) {
59+
this._rejecter(err);
60+
}
5961
this._resolver = null;
6062
this._rejecter = null;
6163
});

js/util/inline-viewer-helper.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@ export class InlineViewerHelper {
4040

4141
this.dirty = false;
4242

43-
canvas.style.cursor = 'grab';
43+
if (canvas.style) {
44+
canvas.style.cursor = 'grab';
45+
}
4446

4547
canvas.addEventListener('mousemove', (event) => {
4648
// Only rotate when the left button is pressed

tests/offscreen-canvas.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
// This sample will create an offscreen canvas for WebGL rather than
6464
// the usual canvas Dom element.
6565
let offscreenCanvas = new OffscreenCanvas(16, 16);
66-
return offscreenCanvas.getContext('webgl', {
66+
return offscreenCanvas.getContext('webgl2', {
6767
xrCompatible: true
6868
});
6969
}

0 commit comments

Comments
 (0)