Fixes #34 adds confirmations to recreate actions

Author: imothee

TmpDisk/StatusBarController.swift

@@ -134,6 +134,15 @@ class StatusBarController {
         return true
     }
 
+    func confirmRecreateAll() -> Bool {
+        let alert = NSAlert()
+        alert.messageText = NSLocalizedString("This will eject and recreate all TmpDisks. All existing data will be lost.", comment: "")
+        alert.alertStyle = .warning
+        alert.addButton(withTitle: "OK")
+        alert.addButton(withTitle: "Cancel")
+        return alert.runModal() == .alertFirstButtonReturn
+    }
+    
     func buildCurrentTmpDiskMenu() {
         self.currentTmpDisksMenu.removeAllItems()
         for volume in TmpDiskManager.shared.volumes {
@@ -163,7 +172,9 @@ class StatusBarController {
     }
 
     @objc func recreateAll(sender: AnyObject) {
-        TmpDiskManager.shared.ejectAllTmpDisks(recreate: true)
+        if confirmRecreateAll() {
+            TmpDiskManager.shared.ejectAllTmpDisks(recreate: true)
+        }
     }
 
     @objc func autoCreateManager(sender: AnyObject) {

TmpDisk/Views/AutoCreateManagerViewController.swift

@@ -169,11 +169,13 @@ class AutoCreateManagerViewController: NSViewController, NSTableViewDelegate, NS
         if let button = sender as? NSButton {
             let row = tableView.row(for: button)
 
-            let volume = self.volumes[row]
-            if TmpDiskManager.shared.exists(volume: volume) {
-                TmpDiskManager.shared.ejectTmpDisksWithName(names: [volume.name], recreate: true)
-            } else {
-                TmpDiskManager.shared.createTmpDisk(volume: volume, onCreate: {_ in })
+            if confirmRecreate() {
+                let volume = self.volumes[row]
+                if TmpDiskManager.shared.exists(volume: volume) {
+                    TmpDiskManager.shared.ejectTmpDisksWithName(names: [volume.name], recreate: true)
+                } else {
+                    TmpDiskManager.shared.createTmpDisk(volume: volume, onCreate: {_ in })
+                }
             }
         }
     }
@@ -187,4 +189,13 @@ class AutoCreateManagerViewController: NSViewController, NSTableViewDelegate, NS
             self.tableView.reloadData()
         }
     }
+    
+    func confirmRecreate() -> Bool {
+        let alert = NSAlert()
+        alert.messageText = NSLocalizedString("This will eject and recreate the TmpDisk. All existing data will be lost.", comment: "")
+        alert.alertStyle = .warning
+        alert.addButton(withTitle: "OK")
+        alert.addButton(withTitle: "Cancel")
+        return alert.runModal() == .alertFirstButtonReturn
+    }
 }