[Fix] enforce-node-protocol-usage: avoid a crash with some TS code

Author: ljharb

CHANGELOG.md

@@ -19,6 +19,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 - configs: added missing name attribute for eslint config inspector ([#3151], thanks [@NishargShah])
 - [`order`]: ensure arcane imports do not cause undefined behavior ([#3128], thanks [@Xunnamius])
 - [`order`]: resolve undefined property access issue when using `named` ordering ([#3166], thanks [@Xunnamius])
+- [`enforce-node-protocol-usage`]: avoid a crash with some TS code ([#3173], thanks [@ljharb])
 
 ### Changed
 - [Docs] [`extensions`], [`order`]: improve documentation ([#3106], thanks [@Xunnamius])
@@ -1175,6 +1176,7 @@ for info on changes for earlier releases.
 
 [`memo-parser`]: ./memo-parser/README.md
 
+[#3173]: https://github.com/import-js/eslint-plugin-import/pull/3173
 [#3167]: https://github.com/import-js/eslint-plugin-import/pull/3167
 [#3166]: https://github.com/import-js/eslint-plugin-import/pull/3166
 [#3151]: https://github.com/import-js/eslint-plugin-import/pull/3151

src/rules/enforce-node-protocol-usage.js

@@ -29,7 +29,7 @@ function replaceStringLiteral(
 }
 
 function isStringLiteral(node) {
-  return node.type === 'Literal' && typeof node.value === 'string';
+  return node && node.type === 'Literal' && typeof node.value === 'string';
 }
 
 function isStaticRequireWith1Param(node) {
@@ -44,7 +44,7 @@ function isStaticRequireWith1Param(node) {
 
 function checkAndReport(src, context) {
   // TODO use src.quasis[0].value.raw
-  if (src.type === 'TemplateLiteral') { return; }
+  if (!src || src.type === 'TemplateLiteral') { return; }
   const moduleName = 'value' in src ? src.value : src.name;
   if (typeof moduleName !== 'string') { console.log(src, moduleName); }
   const { settings } = context;

tests/src/rules/enforce-node-protocol-usage.js

@@ -2,7 +2,7 @@ import { RuleTester } from '../rule-tester';
 import flatMap from 'array.prototype.flatmap';
 import { satisfies } from 'semver';
 
-import { test, testVersion } from '../utils';
+import { getTSParsers, test, testVersion } from '../utils';
 
 const ruleTester = new RuleTester();
 const rule = require('rules/enforce-node-protocol-usage');
@@ -343,3 +343,28 @@ ruleTester.run('enforce-node-protocol-usage', rule, {
     })),
   ),
 });
+
+context('TypeScript', function () {
+  getTSParsers().forEach((parser) => {
+    ruleTester.run('enforce-node-protocol-usage', rule, {
+      valid: [
+        test({
+          code: `
+            export class Thing {
+              constructor(public readonly name: string) {
+                  // Do nothing.
+              }
+
+              public sayHello(): void {
+                  console.log(\`Hello, \${this.name}!\`);
+              }
+            }
+          `,
+          parser,
+          options: preferUsingProtocol,
+        }),
+      ],
+      invalid: [],
+    });
+  });
+});