Merge branch 'master' of https://github.com/WordImpress/Give-ConvertKit

* 'master' of https://github.com/WordImpress/Give-ConvertKit:
  give_get_option to fix notice pass 2
  give_get_option to fix notice
  get_list returns array to fix notice
  use give_get_option to fix notices
  Update hook give_purchase_form_before_submit --> give_donation_form_before_submit

Author: Devin Walker

includes/class-give-convertkit.php

@@ -196,7 +196,7 @@ public function form_fields( $form_id ) {
 
 		//What's the check gonna be? Should the opt-on be checked or unchecked by default...
 		$form_checked_option   = get_post_meta( $form_id, '_give_' . $this->id . '_checked_default', true );
-		$global_checked_option = $this->give_options[ 'give_' . $this->id . '_checked_default' ];
+		$global_checked_option = give_get_option( "give_{$this->id}_checked_default" );
 		$checked_option        = 'enabled';
 
 		if ( ! empty( $form_checked_option ) && $override_option !== 'default' ) {
@@ -401,7 +401,7 @@ public function render_metabox() {
 
 		//Form select
 		$list_value = get_post_meta( $post->ID, '_give_' . $this->id, true );
-		$list_value = ! empty( $list_value ) ? $list_value : $this->give_options[ 'give_' . $this->id . '_list' ];
+		$list_value = ! empty( $list_value ) ? $list_value : give_get_option( "give_{$this->id}_list" );
 
 		//Global label
 		$global_label = isset( $this->give_options[ 'give_' . $this->id . '_label' ] ) ? $this->give_options[ 'give_' . $this->id . '_label' ] : __( 'Signup for the newsletter', 'give-convertkit' );;
@@ -600,7 +600,7 @@ public function save_metabox( $post_id ) {
 
 		// Sanitize the user input.
 		$give_custom_label      = isset( $_POST[ '_give_' . $this->id . '_custom_label' ] ) ? sanitize_text_field( $_POST[ '_give_' . $this->id . '_custom_label' ] ) : '';
-		$give_custom_lists      = isset( $_POST[ '_give_' . $this->id ] ) ? $_POST[ '_give_' . $this->id ] : $this->give_options[ 'give_' . $this->id . '_list' ];
+		$give_custom_lists      = isset( $_POST[ '_give_' . $this->id ] ) ? $_POST[ '_give_' . $this->id ] : give_get_option( "give_{$this->id}_list" );
 		$give_custom_tags       = isset( $_POST[ '_give_' . $this->id ] ) ? $_POST[ '_give_' . $this->id . '_tags' ] : $this->give_options[ 'give_' . $this->id . '_tags' ];
 		$give_override_option   = isset( $_POST[ '_give_' . $this->id . '_override_option' ] ) ? esc_html( $_POST[ '_give_' . $this->id . '_override_option' ] ) : '';
 		$give_subscribe_checked = isset( $_POST[ '_give_' . $this->id . '_checked_default' ] ) ? esc_html( $_POST[ '_give_' . $this->id . '_checked_default' ] ) : '';
@@ -619,7 +619,7 @@ public function save_metabox( $post_id ) {
 	/**
 	 * Retrieves the lists from ConvertKit
 	 *
-	 * @return mixed
+	 * @return array
 	 */
 	public function get_lists() {
 
@@ -653,7 +653,7 @@ public function get_lists() {
 
 		}
 
-		return $this->lists;
+		return (array) $this->lists;
 
 	}
 
@@ -780,7 +780,7 @@ public function settings( $settings ) {
 	public function show_subscribe_checkbox( $form_id ) {
 
 		$override_option = get_post_meta( $form_id, '_give_' . $this->id . '_override_option', true );
-		$global_option   = $this->give_options[ 'give_' . $this->id . '_show_subscribe_checkbox' ];
+		$global_option   = give_get_option( "give_{$this->id}_show_subscribe_checkbox" );
 
 		//Is disabled on the form?
 		if ( $override_option == 'disabled' ) {