TypeError on Give Stripe Webhook handler

[jessewaitz]

I am getting multiple errors in the stripe webhook handler of your "give-recurring" addon. This error has been logged in our sentry error logging system about 14 times in the last couple months, and 7 times in the last 30 days. Here is the file/line where this is happening.

/wp-content/plugins/give-recurring/src/Webhooks/Stripe/Listeners/CustomerSubscriptionUpdated.php in GiveRecurring\Webhooks\Stripe\Listeners\CustomerSubscriptionUpdated::isSubscriptionProcessable at line 77

The PHP TypeError is as a follows:

GiveRecurring\Webhooks\Stripe\Listeners\CustomerSubscriptionUpdated::isSubscriptionProcessable(): Argument #2 ($subscription) must be of type Give\Subscriptions\Models\Subscription, null given, called in /wp-content/plugins/give-recurring/src/Webhooks/Stripe/Listeners/CustomerSubscriptionUpdated.php on line 34

Looks like you need to add a null check everywhere else in the code that this "isSubscriptionProcessable" method is called so that this logic will not fail.

I have attached a text file containing a redacted stripe JSON payload that caused this error to happen. I am also including a text file with the full stack trace of this error. I don't know if these will help you understand where the null is coming from, but it should be useful for back tracing the error. Please let me know if you need further explanation or more information on this error.

stripe-webhook-error-stack.txt
stripe-webook-payload-redacted.txt