Skip to content

Wrong date when importing donations #6595

Open
@Genevieve-K

Description

@Genevieve-K

User Story

As a admin, I want to export donations and import them in a new site.

Details

The date of donation is sometimes wrong.

Steps to Reproduce

  1. In WP settings > General, choose the format d/m/Y ( 27/10/2022 )
  2. Export the donations
  3. In another site, import the donations
  4. Some donations have the today date, other are not visible because they are in the futur.
  5. The donations in the future gives an 400 error in some new functions: Value 'future' is not part of the enum Give\Donations\ValueObjects\DonationStatus.
  6. We cannot delete the donations in the future.

Raison

In import-functions.php, the date is defined by: $post_date = mysql2date( 'Y-m-d', $data['post_date'] );
However, the mysql2date() suppse that the imput format is m/d/Y if the separator is a slash.
So '10/11/2022' becomes '11/10/2022' in the future.
And '27/10/2022' is an unexisting date.
I suggest to use the format selected in WP settings, with get_option('date_format').

I worked around by changing the settings before export the donations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    keep-fresh"Keep Fresh" issues should not be marked as stale.type: bugExisting functionality is broken

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions