Skip to content

Commit 588a943

Browse files
fix(pipeline): use ESRP_SERVICE_CONNECTION variable and MSI auth
All 5 ESRP tasks now use $(ESRP_SERVICE_CONNECTION) instead of hardcoded service connection name. EsrpCodeSigning@5 steps aligned with EsrpRelease@11 pattern: UseMSIAuth + service connection. Removed AuthCertName (not needed with managed identity auth). Kept AuthSignCertName for the signing certificate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 039bae8 commit 588a943

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

pipelines/esrp-publish.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ stages:
191191
- task: EsrpRelease@11
192192
displayName: 'ESRP Publish ${{ pkg.name }} to PyPI'
193193
inputs:
194-
connectedservicename: 'Agent Governance Toolkit'
194+
connectedservicename: '$(ESRP_SERVICE_CONNECTION)'
195195
usemanagedidentity: true
196196
keyvaultname: '$(ESRP_KEYVAULT_NAME)'
197197
signcertname: '$(ESRP_CERT_IDENTIFIER)'
@@ -280,7 +280,7 @@ stages:
280280
- task: EsrpRelease@11
281281
displayName: 'ESRP Publish to npm'
282282
inputs:
283-
connectedservicename: 'Agent Governance Toolkit'
283+
connectedservicename: '$(ESRP_SERVICE_CONNECTION)'
284284
usemanagedidentity: true
285285
keyvaultname: '$(ESRP_KEYVAULT_NAME)'
286286
signcertname: '$(ESRP_CERT_IDENTIFIER)'
@@ -383,11 +383,11 @@ stages:
383383
- task: EsrpCodeSigning@5
384384
displayName: 'ESRP Authenticode sign DLLs'
385385
inputs:
386-
ConnectedServiceName: 'Agent Governance Toolkit'
386+
ConnectedServiceName: '$(ESRP_SERVICE_CONNECTION)'
387+
UseMSIAuth: true
387388
AppRegistrationClientId: '$(ESRP_CLIENT_ID)'
388389
AppRegistrationTenantId: '$(MICROSOFT_TENANT_ID)'
389390
AuthAKVName: '$(ESRP_KEYVAULT_NAME)'
390-
AuthCertName: '$(ESRP_AUTH_CERT_NAME)'
391391
AuthSignCertName: '$(ESRP_CERT_IDENTIFIER)'
392392
FolderPath: '$(Pipeline.Workspace)\nuget-unsigned'
393393
Pattern: '*.dll'
@@ -435,11 +435,11 @@ stages:
435435
- task: EsrpCodeSigning@5
436436
displayName: 'ESRP Code Sign NuGet package'
437437
inputs:
438-
ConnectedServiceName: 'Agent Governance Toolkit'
438+
ConnectedServiceName: '$(ESRP_SERVICE_CONNECTION)'
439+
UseMSIAuth: true
439440
AppRegistrationClientId: '$(ESRP_CLIENT_ID)'
440441
AppRegistrationTenantId: '$(MICROSOFT_TENANT_ID)'
441442
AuthAKVName: '$(ESRP_KEYVAULT_NAME)'
442-
AuthCertName: '$(ESRP_AUTH_CERT_NAME)'
443443
AuthSignCertName: '$(ESRP_CERT_IDENTIFIER)'
444444
FolderPath: '$(Pipeline.Workspace)\nuget-unsigned'
445445
Pattern: '*.nupkg'
@@ -559,7 +559,7 @@ stages:
559559
- task: EsrpRelease@11
560560
displayName: 'ESRP Publish to crates.io'
561561
inputs:
562-
connectedservicename: 'Agent Governance Toolkit'
562+
connectedservicename: '$(ESRP_SERVICE_CONNECTION)'
563563
usemanagedidentity: true
564564
keyvaultname: '$(ESRP_KEYVAULT_NAME)'
565565
signcertname: '$(ESRP_CERT_IDENTIFIER)'

0 commit comments

Comments
 (0)