Skip to content

Commit 8420e0f

Browse files
fix(pipeline): add AuthCertName for ESRP cert-based auth
ESRP fails with "AuthCertName should be set" because the service connection uses cert-based auth but the pipeline only had AuthSignCertName (signing cert) without AuthCertName (auth cert). UseMSIAuth:true was also set but ignored since the connection is cert-based, causing confusion. Fix for both Authenticode DLL signing and NuGet package signing: - Remove UseMSIAuth: true (not used by this service connection) - Add AuthCertName sourced from ESRP_AUTH_CERT_NAME pipeline variable ADO action required: Add ESRP_AUTH_CERT_NAME pipeline variable pointing to the authentication certificate name in Key Vault. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 2bd3c91 commit 8420e0f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

pipelines/esrp-publish.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,10 +384,10 @@ stages:
384384
displayName: 'ESRP Authenticode sign DLLs'
385385
inputs:
386386
ConnectedServiceName: 'Agent Governance Toolkit'
387-
UseMSIAuth: true
388387
AppRegistrationClientId: '$(ESRP_CLIENT_ID)'
389388
AppRegistrationTenantId: '$(MICROSOFT_TENANT_ID)'
390389
AuthAKVName: '$(ESRP_KEYVAULT_NAME)'
390+
AuthCertName: '$(ESRP_AUTH_CERT_NAME)'
391391
AuthSignCertName: '$(ESRP_CERT_IDENTIFIER)'
392392
FolderPath: '$(Pipeline.Workspace)\nuget-unsigned'
393393
Pattern: '*.dll'
@@ -436,10 +436,10 @@ stages:
436436
displayName: 'ESRP Code Sign NuGet package'
437437
inputs:
438438
ConnectedServiceName: 'Agent Governance Toolkit'
439-
UseMSIAuth: true
440439
AppRegistrationClientId: '$(ESRP_CLIENT_ID)'
441440
AppRegistrationTenantId: '$(MICROSOFT_TENANT_ID)'
442441
AuthAKVName: '$(ESRP_KEYVAULT_NAME)'
442+
AuthCertName: '$(ESRP_AUTH_CERT_NAME)'
443443
AuthSignCertName: '$(ESRP_CERT_IDENTIFIER)'
444444
FolderPath: '$(Pipeline.Workspace)\nuget-unsigned'
445445
Pattern: '*.nupkg'

0 commit comments

Comments
 (0)