Skip to content

Commit 1678f7a

Browse files
committed
Revert using a method to check tagging prevention reason
1 parent 34ddcc7 commit 1678f7a

File tree

1 file changed

+12
-21
lines changed

1 file changed

+12
-21
lines changed

osu.Game/Screens/Ranking/Statistics/StatisticsPanel.cs

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -90,21 +90,6 @@ private void load(AudioManager audio)
9090
popOutSample = audio.Samples.Get(@"Results/statistics-panel-pop-out");
9191
}
9292

93-
private string? getReasonFromPreventingTagging(ScoreInfo? score, int expectedRulesetId)
94-
{
95-
// We may want to iterate on the following conditions further in the future
96-
if (score == null)
97-
return "Play the beatmap to contribute to beatmap tags!";
98-
else if (score.Ruleset.OnlineID != expectedRulesetId)
99-
return "Play the beatmap in its original ruleset to contribute to beatmap tags!";
100-
else if (score.Rank < ScoreRank.C)
101-
return "Set a better score to contribute to beatmap tags!";
102-
else if (score.Mods.Any(m => (m.Type == ModType.Conversion) && !(m is ModClassic)))
103-
return "Play this beatmap without conversion mods to contribute to beatmap tags!";
104-
else
105-
return null;
106-
}
107-
10893
private void populateStatistics(ValueChangedEvent<ScoreInfo?> score)
10994
{
11095
loadCancellation?.Cancel();
@@ -257,7 +242,6 @@ protected virtual IEnumerable<StatisticItem> CreateStatisticItems(ScoreInfo newS
257242
&& api.IsLoggedIn)
258243
{
259244
string? preventTaggingReason = null;
260-
int expectedRulesetID = newScore.BeatmapInfo.Ruleset.OnlineID;
261245

262246
var localUserScores = realm.Run(r =>
263247
r.GetAllLocalScoresForUser(api.LocalUser.Value.Id)
@@ -268,16 +252,23 @@ protected virtual IEnumerable<StatisticItem> CreateStatisticItems(ScoreInfo newS
268252
.ToArray());
269253

270254
if (localUserScores.Length == 0)
271-
preventTaggingReason = getReasonFromPreventingTagging(AchievedScore, expectedRulesetID);
255+
preventTaggingReason = "Play the beatmap to contribute to beatmap tags!";
272256
else
273-
{
274257
foreach (ScoreInfo score in localUserScores)
275258
{
276-
preventTaggingReason = getReasonFromPreventingTagging(score, expectedRulesetID);
277-
if (preventTaggingReason == null)
259+
// We may want to iterate on the following conditions further in the future
260+
if (score.Ruleset.OnlineID != newScore.BeatmapInfo.Ruleset.OnlineID)
261+
preventTaggingReason = "Play the beatmap in its original ruleset to contribute to beatmap tags!";
262+
else if (score.Rank < ScoreRank.C)
263+
preventTaggingReason = "Set a better score to contribute to beatmap tags!";
264+
else if (score.Mods.Any(m => (m.Type == ModType.Conversion) && !(m is ModClassic)))
265+
preventTaggingReason = "Play this beatmap without conversion mods to contribute to beatmap tags!";
266+
else
267+
{
268+
preventTaggingReason = null;
278269
break;
270+
}
279271
}
280-
}
281272

282273
if (preventTaggingReason == null)
283274
{

0 commit comments

Comments
 (0)