Skip to content

Commit fa91d23

Browse files
bdachbdach
authored
Merge branch 'master' into tagging-use-available-score
2 parents 6a1beaa + b98cf42 commit fa91d23

File tree

176 files changed

+2193
-2501
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

176 files changed

+2193
-2501
lines changed

‎.config/dotnet-tools.json‎

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,28 +3,25 @@
33
"isRoot": true,
44
"tools": {
55
"jetbrains.resharper.globaltools": {
6-
"version": "2023.3.3",
6+
"version": "2025.2.3",
77
"commands": [
88
"jb"
9-
]
10-
},
11-
"nvika": {
12-
"version": "4.0.0",
13-
"commands": [
14-
"nvika"
15-
]
9+
],
10+
"rollForward": false
1611
},
1712
"codefilesanity": {
1813
"version": "0.0.37",
1914
"commands": [
2015
"CodeFileSanity"
21-
]
16+
],
17+
"rollForward": false
2218
},
2319
"ppy.localisationanalyser.tools": {
2420
"version": "2025.1208.0",
2521
"commands": [
2622
"localisation"
27-
]
23+
],
24+
"rollForward": false
2825
}
2926
}
30-
}
27+
}

‎.github/workflows/_diffcalc_processor.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444

4545
steps:
4646
- name: Checkout diffcalc-sheet-generator
47-
uses: actions/checkout@v4
47+
uses: actions/checkout@v6
4848
with:
4949
path: ${{ inputs.id }}
5050
repository: 'smoogipoo/diffcalc-sheet-generator'

‎.github/workflows/ci.yml‎

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,18 @@ concurrency:
66

77
permissions:
88
contents: read # to fetch code (actions/checkout)
9+
security-events: write # for reporting InspectCode issues
910

1011
jobs:
1112
inspect-code:
1213
name: Code Quality
1314
runs-on: ubuntu-latest
1415
steps:
1516
- name: Checkout
16-
uses: actions/checkout@v4
17+
uses: actions/checkout@v6
1718

1819
- name: Install .NET 8.0.x
19-
uses: actions/setup-dotnet@v4
20+
uses: actions/setup-dotnet@v5
2021
with:
2122
dotnet-version: "8.0.x"
2223

@@ -27,7 +28,7 @@ jobs:
2728
run: dotnet restore osu.Desktop.slnf
2829

2930
- name: Restore inspectcode cache
30-
uses: actions/cache@v4
31+
uses: actions/cache@v5
3132
with:
3233
path: ${{ github.workspace }}/inspectcode
3334
key: inspectcode-${{ hashFiles('.config/dotnet-tools.json', '.github/workflows/ci.yml', 'osu.sln*', 'osu*.slnf', '.editorconfig', '.globalconfig', 'CodeAnalysis/*', '**/*.csproj', '**/*.props') }}
@@ -49,10 +50,14 @@ jobs:
4950
exit $exit_code
5051
5152
- name: InspectCode
52-
run: dotnet jb inspectcode $(pwd)/osu.Desktop.slnf --no-build --output="inspectcodereport.xml" --caches-home="inspectcode" --verbosity=WARN
53-
54-
- name: NVika
55-
run: dotnet nvika parsereport "${{github.workspace}}/inspectcodereport.xml" --treatwarningsaserrors
53+
uses: JetBrains/ReSharper-InspectCode@v0.11
54+
with:
55+
# this is WTF tier but if you don't specify *both* of these the defaults assume `build: true`
56+
build: false
57+
no-build: true
58+
solution: ./osu.Desktop.slnf
59+
caches-home: inspectcode
60+
verbosity: WARN
5661

5762
test:
5863
name: Test
@@ -71,10 +76,10 @@ jobs:
7176
timeout-minutes: 120
7277
steps:
7378
- name: Checkout
74-
uses: actions/checkout@v4
79+
uses: actions/checkout@v6
7580

7681
- name: Install .NET 8.0.x
77-
uses: actions/setup-dotnet@v4
82+
uses: actions/setup-dotnet@v5
7883
with:
7984
dotnet-version: "8.0.x"
8085

@@ -98,7 +103,7 @@ jobs:
98103
# Attempt to upload results even if test fails.
99104
# https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#always
100105
- name: Upload Test Results
101-
uses: actions/upload-artifact@v4
106+
uses: actions/upload-artifact@v7
102107
if: ${{ always() }}
103108
with:
104109
name: osu-test-results-${{matrix.os.prettyname}}-${{matrix.threadingMode}}
@@ -110,16 +115,16 @@ jobs:
110115
timeout-minutes: 60
111116
steps:
112117
- name: Checkout
113-
uses: actions/checkout@v4
118+
uses: actions/checkout@v6
114119

115120
- name: Setup JDK 11
116-
uses: actions/setup-java@v4
121+
uses: actions/setup-java@v5
117122
with:
118123
distribution: microsoft
119124
java-version: 11
120125

121126
- name: Install .NET 8.0.x
122-
uses: actions/setup-dotnet@v4
127+
uses: actions/setup-dotnet@v5
123128
with:
124129
dotnet-version: "8.0.x"
125130

@@ -135,10 +140,10 @@ jobs:
135140
timeout-minutes: 60
136141
steps:
137142
- name: Checkout
138-
uses: actions/checkout@v4
143+
uses: actions/checkout@v6
139144

140145
- name: Install .NET 8.0.x
141-
uses: actions/setup-dotnet@v4
146+
uses: actions/setup-dotnet@v5
142147
with:
143148
dotnet-version: "8.0.x"
144149

‎.github/workflows/deploy.yml‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ name: Pack and nuget
33
on:
44
push:
55
tags:
6-
- '*'
6+
- '*.*.*'
7+
- '!*-*'
78

89
jobs:
910
notify_pending_production_deploy:
@@ -43,14 +44,14 @@ jobs:
4344
environment: production
4445
steps:
4546
- name: Checkout
46-
uses: actions/checkout@v4
47+
uses: actions/checkout@v6
4748

4849
- name: Set artifacts directory
4950
id: artifactsPath
5051
run: echo "::set-output name=nuget_artifacts::${{github.workspace}}/artifacts"
5152

5253
- name: Install .NET 8.0.x
53-
uses: actions/setup-dotnet@v4
54+
uses: actions/setup-dotnet@v5
5455
with:
5556
dotnet-version: "8.0.x"
5657

@@ -76,7 +77,7 @@ jobs:
7677
dotnet pack -c Release Templates /p:Version=${{ github.ref_name }} -o ${{steps.artifactsPath.outputs.nuget_artifacts}}
7778
7879
- name: Upload artifacts
79-
uses: actions/upload-artifact@v4
80+
uses: actions/upload-artifact@v7
8081
with:
8182
name: osu
8283
path: |

‎.github/workflows/report-nunit.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,21 @@ jobs:
2222
timeout-minutes: 5
2323
steps:
2424
- name: Checkout
25-
uses: actions/checkout@v4
25+
uses: actions/checkout@v6
2626
with:
2727
repository: ${{ github.event.workflow_run.repository.full_name }}
2828
ref: ${{ github.event.workflow_run.head_sha }}
2929

3030
- name: Download results
31-
uses: actions/download-artifact@v4
31+
uses: actions/download-artifact@v8
3232
with:
3333
pattern: osu-test-results-*
3434
merge-multiple: true
3535
run-id: ${{ github.event.workflow_run.id }}
3636
github-token: ${{ github.token }}
3737

3838
- name: Annotate CI run with test results
39-
uses: dorny/test-reporter@v1.8.0
39+
uses: dorny/test-reporter@v2.6.0
4040
with:
4141
name: Results
4242
path: "*.trx"

‎.github/workflows/sentry-release.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ jobs:
1313
runs-on: ubuntu-latest
1414
steps:
1515
- name: Checkout
16-
uses: actions/checkout@v4
16+
uses: actions/checkout@v6
1717
with:
1818
fetch-depth: 0
1919

2020
- name: Create Sentry release
21-
uses: getsentry/action-release@v1
21+
uses: getsentry/action-release@v3
2222
env:
2323
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
2424
SENTRY_ORG: ppy

‎.github/workflows/update-web-mod-definitions.yml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,12 @@ jobs:
3838
run: ./UseLocalOsu.sh
3939
working-directory: ./osu-tools
4040

41+
- name: Build tools
42+
run: dotnet build PerformanceCalculator --nologo --verbosity quiet
43+
working-directory: ./osu-tools
44+
4145
- name: Regenerate mod definitions
42-
run: dotnet run --project PerformanceCalculator -- mods > ../osu-web/database/mods.json
46+
run: dotnet run --project PerformanceCalculator --no-build -- mods > ../osu-web/database/mods.json
4347
working-directory: ./osu-tools
4448

4549
- name: Create pull request with changes

‎Templates/Rulesets/ruleset-empty/osu.Game.Rulesets.EmptyFreeform.Tests/osu.Game.Rulesets.EmptyFreeform.Tests.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
</PropertyGroup>
1111
<ItemGroup Label="Package References">
1212
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
13-
<PackageReference Include="NUnit" Version="3.14.0" />
14-
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
13+
<PackageReference Include="NUnit" Version="4.5.1" />
14+
<PackageReference Include="NUnit3TestAdapter" Version="6.1.0" />
1515
</ItemGroup>
1616
<ItemGroup>
1717
<ProjectReference Include="..\osu.Game.Rulesets.EmptyFreeform\osu.Game.Rulesets.EmptyFreeform.csproj" />

‎Templates/Rulesets/ruleset-example/osu.Game.Rulesets.Pippidon.Tests/osu.Game.Rulesets.Pippidon.Tests.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
</PropertyGroup>
1111
<ItemGroup Label="Package References">
1212
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
13-
<PackageReference Include="NUnit" Version="3.14.0" />
14-
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
13+
<PackageReference Include="NUnit" Version="4.5.1" />
14+
<PackageReference Include="NUnit3TestAdapter" Version="6.1.0" />
1515
</ItemGroup>
1616
<ItemGroup>
1717
<ProjectReference Include="..\osu.Game.Rulesets.Pippidon\osu.Game.Rulesets.Pippidon.csproj" />

‎Templates/Rulesets/ruleset-scrolling-empty/osu.Game.Rulesets.EmptyScrolling.Tests/osu.Game.Rulesets.EmptyScrolling.Tests.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
</PropertyGroup>
1111
<ItemGroup Label="Package References">
1212
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
13-
<PackageReference Include="NUnit" Version="3.14.0" />
14-
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
13+
<PackageReference Include="NUnit" Version="4.5.1" />
14+
<PackageReference Include="NUnit3TestAdapter" Version="6.1.0" />
1515
</ItemGroup>
1616
<ItemGroup>
1717
<ProjectReference Include="..\osu.Game.Rulesets.EmptyScrolling\osu.Game.Rulesets.EmptyScrolling.csproj" />

0 commit comments

Comments
 (0)