[RELEASE] Version 9.3.1 with fixes for TCA pre proc., empty pointer values and deleted records

Author: vertexvaar

CHANGELOG.md

@@ -1,5 +1,13 @@
 # In2publish Core Change Log
 
+9.3.1:
+
+- [META] Set the EM conf version number to 9.3.1
+- [BUGFIX] Define TCA user fields as unfit for relation resolving
+- [BUGFIX] Limit "treatRemovedAndDeletedAsDifference" to actual removed and deleted records
+- [BUGFIX] Fallback to foreign's sys_file_processedfile sys_file pointer value
+- [RELEASE] Version 9.3.0 with publish page context menu entry, file edge cache invalidation, and much more-
+
 9.3.0:
 
 - [META] Set the branch alias version number to 9.3.x-dev

Classes/Domain/Factory/RecordFactory.php

@@ -274,9 +274,17 @@ public function makeInstance(
             if (empty($tableConfiguration)) {
                 switch ($tableName) {
                     case 'sys_file_processedfile':
-                        $identifier = $instance->getLocalProperty('original');
-                        $record = $commonRepository->findByIdentifier($identifier, 'sys_file');
-                        $instance->addRelatedRecord($record);
+                        $identifier = null;
+                        if ($instance->localRecordExists()) {
+                            $identifier = $instance->getLocalProperty('original');
+                        }
+                        if (empty($identifier) && $instance->foreignRecordExists()) {
+                            $identifier = $instance->getForeignProperty('original');
+                        }
+                        if (!empty($identifier)) {
+                            $record = $commonRepository->findByIdentifier($identifier, 'sys_file');
+                            $instance->addRelatedRecord($record);
+                        }
                         break;
                     default:
                 }

Classes/Domain/Repository/CommonRepository.php

@@ -1908,7 +1908,14 @@ protected function isIgnoredRecord(array $localProperties, array $foreignPropert
     protected function isRemovedAndDeletedRecord(array $localProps, array $foreignProps): bool
     {
         if ($this->configContainer->get('factory.treatRemovedAndDeletedAsDifference')) {
-            return false;
+            // "Removed and deleted" only refers to the local side.
+            // If the record is not exactly 1. deleted on foreign and 2. removed on local this feature does not apply.
+            if (empty($localProps)
+                && array_key_exists('deleted', $foreignProps)
+                && 1 === (int)$foreignProps['deleted']
+            ) {
+                return false;
+            }
         }
         return (empty($localProps) && isset($foreignProps['deleted']) && 1 === (int)$foreignProps['deleted'])
                || (empty($foreignProps) && isset($localProps['deleted']) && 1 === (int)$localProps['deleted']);
@@ -1938,7 +1945,7 @@ protected function isDeletedAndUnchangedRecord(array $localProperties, array $fo
      * @return void
      * @throws Throwable
      */
-    public function publishRecordRecursive(RecordInterface $record, array $excludedTables = ['pages'])
+    public function publishRecordRecursive(RecordInterface $record, array $excludedTables = ['p ages'])
     {
         try {
             // Dispatch Anomaly

Classes/Domain/Service/Processor/UserProcessor.php

@@ -35,16 +35,7 @@
 class UserProcessor extends AbstractProcessor
 {
     /**
-     * Overwrite and set TRUE for types like "select" or "inline"
-     *
      * @var bool
      */
-    protected $canHoldRelations = true;
-
-    /**
-     * @var array
-     */
-    protected $forbidden = [
-        'itemsProcFunc is not supported' => self::ITEMS_PROC_FUNC,
-    ];
+    protected $canHoldRelations = false;
 }

ext_emconf.php

@@ -4,7 +4,7 @@
     'title' => 'in2publish Core',
     'description' => 'Content publishing extension to connect stage and production server',
     'category' => 'plugin',
-    'version' => '9.3.0',
+    'version' => '9.3.1',
     'state' => 'stable',
     'uploadfolder' => 0,
     'createDirs' => '',