[RELEASE] Version 9.1.0 with translated record handling and support info

Author: vertexvaar

CHANGELOG.md

@@ -1,5 +1,23 @@
 # In2publish Core Change Log
 
+9.1.0:
+
+- [META] Set the branch alias version number to 9.1.x-dev
+- [META] Set the EM conf version number to 9.1.0
+- [BUGFIX] Run tasks after publishing files and folders
+- [FEATURE] Handle translated records as a special kind of record
+- [BUGFIX] Include translated records in changed state calculation
+- [FEATURE] Identify translations of records as special records, display with flag
+- [BUGFIX] Do not attempt to modify preview URLs of files which already are full qualified
+- [BUGFIX] Inherit the correct FQCN from the changed EXT:logs controller
+- [BUGFIX] Allow FlexForm config arrays without TCEforms index
+- [BUGFIX] Prevent PageTS caching before ext_tables and the TCA is loaded
+- [FEATURE] Show support info in publish tools module index
+- [DOCS] Add known issue about typo3/cms-redirects
+- [BUGFIX] Build compare URIs with the correct arguments for cHash calculation
+- [BUGFIX] Do not rely on the internal implementation of ArrayObject
+- [RELEASE] Version 9.0.2 with fixed RCE option type
+
 9.0.2:
 
 - [META] Set the EM conf version number to 9.0.1

Classes/Config/Node/Generic/GenInteger.php

@@ -59,7 +59,8 @@ public function cast($value): array
     {
         $tmp = [];
         foreach ($value as $key => $var) {
-            $valueNode = reset($this->nodes);
+            $nodes = $this->nodes->getArrayCopy();
+            $valueNode = reset($nodes);
             $casted = $valueNode->cast($var);
             $tmp[(int)$key] = $casted;
             unset($value[$key]);

Classes/Config/Node/Generic/GenString.php

@@ -59,7 +59,8 @@ public function cast($value): array
     {
         $tmp = [];
         foreach ($value as $key => $var) {
-            $tmp[(string)$key] = reset($this->nodes)->cast($var);
+            $nodes = $this->nodes->getArrayCopy();
+            $tmp[(string)$key] = reset($nodes)->cast($var);
             unset($value[$key]);
         }
         return $tmp;

Classes/Config/Provider/PageTsProvider.php

@@ -34,19 +34,35 @@
 use In2code\In2publishCore\Utility\DatabaseUtility;
 use TYPO3\CMS\Backend\Utility\BackendUtility as CoreBackendUtility;
 use TYPO3\CMS\Core\Database\Connection;
+use TYPO3\CMS\Core\Database\TableConfigurationPostProcessingHookInterface;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**
  * Class PageTsProvider
  */
-class PageTsProvider implements ProviderInterface, ContextualProvider
+class PageTsProvider implements ProviderInterface, ContextualProvider, TableConfigurationPostProcessingHookInterface
 {
+    /**
+     * @var bool
+     */
+    protected $locked = true;
+
+    /**
+     * This method is called after loading all ext_tables.php
+     * The PageTS provider is locked until that point to prevent premature loading and therefore caching of the PageTS.
+     * (e.g. flux registers content elements for the NewContentElementWizard dynamically after ext_tables.php loading)
+     */
+    public function processData()
+    {
+        $this->locked = false;
+    }
+
     /**
      * @return bool
      */
     public function isAvailable()
     {
-        return $this->getDatabase() instanceof Connection;
+        return !$this->locked && $this->getDatabase() instanceof Connection;
     }
 
     /**

Classes/Controller/FileController.php

@@ -81,6 +81,7 @@ public function indexAction()
     public function publishFolderAction($identifier)
     {
         $success = GeneralUtility::makeInstance(FolderPublisherService::class)->publish($identifier);
+        $this->runTasks();
 
         if ($success) {
             $this->addFlashMessage(
@@ -144,6 +145,7 @@ public function publishFileAction($uid, $identifier, $storage)
                     LocalizationUtility::translate('file_publishing.failure', 'in2publish_core')
                 );
             }
+            $this->runTasks();
         }
 
         try {

Classes/Controller/ToolsController.php

@@ -133,6 +133,17 @@ public function indexAction()
             );
         }
 
+        $supports = [
+            LocalizationUtility::translate('help.github_issues', 'in2publish_core'),
+            LocalizationUtility::translate('help.slack_channel', 'in2publish_core'),
+        ];
+        [$supports] = $this->signalSlotDispatcher->dispatch(
+            ToolsController::class,
+            'collectSupportPlaces',
+            [$supports]
+        );
+        $this->view->assign('supports', $supports);
+
         $this->view->assign('tools', GeneralUtility::makeInstance(ToolsRegistry::class)->getTools());
     }
 

Classes/Domain/Factory/RecordFactory.php

@@ -627,13 +627,9 @@ public function endSimulation()
     /**
      * @param RecordInterface $record
      * @param CommonRepository $commonRepository
-     * @param string|null $forceRelatedRecordTable
      */
-    protected function findTranslations(
-        RecordInterface $record,
-        CommonRepository $commonRepository,
-        string $forceRelatedRecordTable = null
-    ) {
+    protected function findTranslations(RecordInterface $record, CommonRepository $commonRepository): void
+    {
         $tableName = $record->getTableName();
 
         $tcaService = GeneralUtility::makeInstance(TcaService::class);
@@ -653,7 +649,7 @@ protected function findTranslations(
                         $tableName
                     );
                     foreach ($translatedRecords as $translatedRecord) {
-                        $record->addRelatedRecordRaw($translatedRecord, $forceRelatedRecordTable ?? $tableName);
+                        $record->addTranslatedRecord($translatedRecord);
                     }
                 }
             }

Classes/Domain/Model/Record.php

@@ -155,6 +155,11 @@ class Record implements RecordInterface
      */
     protected $configContainer;
 
+    /**
+     * @var RecordInterface[]
+     */
+    protected $translatedRecords = [];
+
     /**
      * @param string $tableName
      * @param array $localProperties
@@ -272,6 +277,11 @@ public function getStateRecursive(array &$alreadyVisited = []): string
         }
         $alreadyVisited[$this->tableName][] = $this->getIdentifier();
         if (!$this->isChanged()) {
+            foreach ($this->getTranslatedRecords() as $translatedRecord) {
+                if ($translatedRecord->isChangedRecursive($alreadyVisited)) {
+                    return static::RECORD_STATE_CHANGED;
+                }
+            }
             foreach ($this->getRelatedRecords() as $tableName => $relatedRecords) {
                 if ($tableName === 'pages') {
                     continue;
@@ -565,6 +575,23 @@ public function getRelatedRecords(): array
         return $this->relatedRecords;
     }
 
+    /**
+     * @return RecordInterface[]
+     */
+    public function getTranslatedRecords(): array
+    {
+        return $this->translatedRecords;
+    }
+
+    /**
+     * @param RecordInterface $record
+     * @return void
+     */
+    public function addTranslatedRecord(RecordInterface $record): void
+    {
+        $this->translatedRecords[$record->getIdentifier()] = $record;
+    }
+
     /**
      * NOTICE: This will not work if debug.disableParentRecords is disabled!
      *
@@ -1206,4 +1233,17 @@ public function isTranslation(): bool
                && array_key_exists($languageField, $this->localProperties)
                && $this->localProperties[$languageField] > 0;
     }
+
+    public function getRecordLanguage(): int
+    {
+        $language = 0;
+
+        $tcaService = GeneralUtility::makeInstance(TcaService::class);
+        $languageField = $tcaService->getLanguageField($this->tableName);
+        if (!empty($languageField) && array_key_exists($languageField, $this->localProperties)) {
+            $language = $this->localProperties[$languageField];
+        }
+
+        return $language;
+    }
 }

Classes/Domain/Model/RecordInterface.php

@@ -218,6 +218,17 @@ public function getMergedProperty($propertyName);
      */
     public function getRelatedRecords(): array;
 
+    /**
+     * @return RecordInterface[]
+     */
+    public function getTranslatedRecords(): array;
+
+    /**
+     * @param RecordInterface $record
+     * @return void
+     */
+    public function addTranslatedRecord(RecordInterface $record): void;
+
     /**
      * NOTICE: This will not work if debug.disableParentRecords is disabled!
      *
@@ -358,4 +369,6 @@ public function getPageIdentifier(): int;
      * @return int
      */
     public function getSuperordinatePageIdentifier(): int;
+
+    public function getRecordLanguage(): int;
 }

Classes/Domain/Repository/CommonRepository.php

@@ -923,6 +923,8 @@ protected function flattenFieldFlexForm(array $flattenedDefinition, array $field
                     }
                 }
             }
+        } elseif (array_key_exists('config', $fieldDefinition)) {
+            $flattenedDefinition[$fieldKey] = $fieldDefinition['config'];
         }
         return $flattenedDefinition;
     }
@@ -2050,6 +2052,9 @@ protected function publishRecordRecursiveInternal(RecordInterface $record, array
      */
     protected function publishRelatedRecordsRecursive(RecordInterface $record, array $excludedTables)
     {
+        foreach ($record->getTranslatedRecords() as $translatedRecord) {
+            $this->publishRecordRecursiveInternal($translatedRecord, $excludedTables);
+        }
         foreach ($record->getRelatedRecords() as $tableName => $relatedRecords) {
             if (!in_array($tableName, $excludedTables) && is_array($relatedRecords)) {
                 /** @var RecordInterface $relatedRecord */