Skip to content

Commit 7c5907c

Browse files
committed
[TASK] Use phpspreadsheet consistently
- raise version numbers - suggest the direct use of `phpoffice/phpspreadsheet` via composer - suggest `EXT:base_excel` for legacy installations - test for class existence of PhpSpreadSheet Related: #1214 Related: #1208
1 parent 1ea1e43 commit 7c5907c

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

Classes/Controller/AbstractController.php

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationExtensionNotConfiguredException;
1717
use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationPathDoesNotExistException;
1818
use TYPO3\CMS\Core\EventDispatcher\EventDispatcher;
19-
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
2019
use TYPO3\CMS\Core\Utility\GeneralUtility;
2120
use TYPO3\CMS\Extbase\Mvc\Controller\ActionController;
2221
use TYPO3\CMS\Extbase\Mvc\Exception\NoSuchArgumentException;
@@ -110,7 +109,7 @@ public function __construct(
110109
$this->uploadService = $uploadService;
111110
$this->eventDispatcher = $eventDispatcher;
112111

113-
$this->isPhpSpreadsheetInstalled = ExtensionManagementUtility::isLoaded('base_excel');
112+
$this->isPhpSpreadsheetInstalled = class_exists(\PhpOffice\PhpSpreadsheet\IOFactory::class);
114113
}
115114

116115
/**

Documentation/Index.md

+6-4
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,13 @@ look at the final output in the frontend.
1717
Some basic points:
1818

1919
- Main features of this mailform extension is to store the mails into
20-
the database. Export it from the backend module (xls, csv) or list the
20+
the database.
21+
22+
- Export it from the backend module (xls, csv) or list the
2123
values in the frontend again (Pi2). XLS export in the backend is only
22-
possible if the extension *jambagecom/base-excel* is installed. In
23-
classic installation, a phar file for phpspreadsheet must be manually
24-
created (See docs of EXT:base_excel).
24+
possible for classic installation, if a phar file for phpspreadsheet is manually
25+
created (See docs of EXT:base_excel). In composer-based installation the neccessary
26+
package is installed automatically.
2527

2628
- Powermail send one or more mails to a static receiver or to dynamic receivers or
2729
to a whole Frontend-User Group.

composer.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
"ext-curl": "*"
4040
},
4141
"suggest": {
42-
"sjbr/static-info-tables": "*",
43-
"jambagecom/base-excel": "^v1.29.0"
42+
"sjbr/static-info-tables": "Provides country information for the country field",
43+
"phpoffice/phpspreadsheet": "Enables xlsx export via the powermail module"
4444
},
4545
"replace": {
4646
"typo3-ter/powermail": "self.version"

ext_emconf.php

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
'conflicts' => [
2020
],
2121
'suggests' => [
22+
'base_excel' => '',
2223
'static_info_tables' => ''
2324
],
2425
],

0 commit comments

Comments
 (0)