Skip to content

Commit f4861e6

Browse files
Hotfix/cross browser compat email template (#62)
* make activate credential email template with tables so it is compatible with all browsers * Changing environment variable for wallet knowledge redirection to email. * chenge register * update version * update version * update enum credential status for pol changes * changes in qr image mail * change img to base64 * update ci-image * update wallet-url * temporary comment * Change in version --------- Co-authored-by: roger <[email protected]>
1 parent b50bbe6 commit f4861e6

File tree

18 files changed

+103
-122
lines changed

18 files changed

+103
-122
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [v1.2.5](https://github.com/in2workspace/in2-issuer-api/releases/tag/v1.2.5)
8+
### Changed
9+
- Changing environment variable for wallet knowledge redirection to email.
10+
- Changed email template implementation for better compatibility.
11+
712
## [v1.2.4](https://github.com/in2workspace/in2-issuer-api/releases/tag/v1.2.3)
813
### Changed
914
- Fix a problem with a cors endpoint.

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ plugins {
1111
}
1212

1313
group = 'es.in2'
14-
version = '1.2.4'
14+
version = '1.2.5'
1515

1616
java {
1717
sourceCompatibility = '17'

src/main/java/es/in2/issuer/application/workflow/impl/VerifiableCredentialIssuanceWorkflowImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ private Mono<Void> sendCredentialOfferEmail(String transactionCode, IssuanceRequ
8080
String email = issuanceRequest.payload().get(MANDATEE).get(EMAIL).asText();
8181
String user = issuanceRequest.payload().get(MANDATEE).get(FIRST_NAME).asText() + " " + issuanceRequest.payload().get(MANDATEE).get(LAST_NAME).asText();
8282
String organization = issuanceRequest.payload().get(MANDATOR).get(ORGANIZATION).asText();
83-
return emailService.sendTransactionCodeForCredentialOffer(email, "Activate your new credential", appConfig.getIssuerUiExternalDomain() + "/credential-offer?transaction_code=" + transactionCode, appConfig.getKnowledgebaseUrl(), user, organization);
83+
return emailService.sendTransactionCodeForCredentialOffer(email, "Activate your new credential", appConfig.getIssuerUiExternalDomain() + "/credential-offer?transaction_code=" + transactionCode, appConfig.getKnowledgebaseWalletUrl(), user, organization);
8484
}
8585

8686
private Mono<Void> sendVcToResponseUri(IssuanceRequest issuanceRequest, String encodedVc, String token) {

src/main/java/es/in2/issuer/domain/model/enums/CredentialStatus.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ public enum CredentialStatus {
55
DRAFT,
66
ISSUED,
77
PEND_DOWNLOAD,
8+
PEND_SIGNATURE,
89
VALID,
910
REVOKED,
1011
EXPIRED

src/main/java/es/in2/issuer/domain/service/EmailService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
public interface EmailService {
66
Mono<Void> sendPin(String to, String subject, String pin);
7-
Mono<Void> sendTransactionCodeForCredentialOffer(String to, String subject, String link, String knowledgebaseUrl, String user, String organization);
7+
Mono<Void> sendTransactionCodeForCredentialOffer(String to, String subject, String link, String knowledgebaseWalletUrl, String user, String organization);
88
Mono<Void> sendPendingCredentialNotification(String to, String subject);
99
Mono<Void> sendCredentialSignedNotification(String to, String subject, String name);
1010
Mono<Void> sendResponseUriFailed(String to, String productId, String guideUrl);

src/main/java/es/in2/issuer/domain/service/impl/EmailServiceImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public Mono<Void> sendPin(String to, String subject, String pin) {
4949
}
5050

5151
@Override
52-
public Mono<Void> sendTransactionCodeForCredentialOffer(String to, String subject, String link, String knowledgebaseUrl, String user, String organization) {
52+
public Mono<Void> sendTransactionCodeForCredentialOffer(String to, String subject, String link, String knowledgebaseWalletUrl, String user, String organization) {
5353
return Mono.fromCallable(() -> {
5454
MimeMessage mimeMessage = javaMailSender.createMimeMessage();
5555
MimeMessageHelper helper = new MimeMessageHelper(mimeMessage, true, UTF_8);
@@ -67,7 +67,7 @@ public Mono<Void> sendTransactionCodeForCredentialOffer(String to, String subjec
6767
context.setVariable("link", link);
6868
context.setVariable("user", user);
6969
context.setVariable("organization", organization);
70-
context.setVariable("knowledgebaseUrl", knowledgebaseUrl);
70+
context.setVariable("knowledgebaseWalletUrl", knowledgebaseWalletUrl);
7171
context.setVariable("imageResourceName", "cid:" + imageResourceName);
7272

7373
String htmlContent = templateEngine.process("activate-credential-email", context);

src/main/java/es/in2/issuer/domain/service/impl/NotificationServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public Mono<Void> sendNotification(String processId, String procedureId) {
3838
email,
3939
"Activate your new credential",
4040
appConfig.getIssuerUiExternalDomain() + "/credential-offer?transaction_code=" + newTransactionCode,
41-
appConfig.getKnowledgebaseUrl(),
41+
appConfig.getKnowledgebaseWalletUrl(),
4242
completeName,
4343
organization
4444
));

src/main/java/es/in2/issuer/infrastructure/config/AppConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ public String getIssuerUiExternalDomain() {
4141
return configAdapter.getConfiguration(issuerUiProperties.externalDomain());
4242
}
4343

44-
public String getKnowledgebaseUrl() {
45-
return configAdapter.getConfiguration(knowledgeBaseProperties.url());
44+
public String getKnowledgebaseWalletUrl() {
45+
return configAdapter.getConfiguration(knowledgeBaseProperties.walletUrl());
4646
}
4747

4848
public String getKnowledgeBaseUploadCertificationGuideUrl() {

src/main/java/es/in2/issuer/infrastructure/config/properties/KnowledgeBaseProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
@ConfigurationProperties(prefix = "knowledge-base")
88
@Validated
99
public record KnowledgeBaseProperties(
10-
@NotNull String url,
10+
@NotNull String walletUrl,
1111
@NotNull String uploadCertificationGuideUrl
1212
) {
1313
}

src/main/resources/application-dev.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ trust-framework:
144144

145145
knowledge-base:
146146
upload-certification-guide-url: "https://knowledgebase.dome-marketplace-prd.org"
147-
url: "https://knowledgebase.dome-marketplace-prd.org"
147+
wallet-url: "https://knowledgebase.dome-marketplace-prd.org/books/dome-digital-wallet-user-guide"
148148

149149
cors:
150150
default-allowed-origins: "https://issuer.dome-marketplace-sbx.org"

0 commit comments

Comments
 (0)