solve pr comments

Author: javieralvarezin2

CHANGELOG.md

@@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Project scaffolding and setup
 
 ### Added
-- Spring Security with Authorization Server configuration, supporting OIDC flows.
+- Spring Security with Authorization Server configuration, supporting OIDC flows (OID4VP flow).
 - Custom authentication filters to handle token requests and authorization code flows.
 - Custom token filters for OIDC token validation and processing.
 - Cryptographic components for ECKey generation (P-256) and managing cryptographic properties

src/main/java/es/in2/vcverifier/config/CacheStore.java

@@ -19,7 +19,6 @@ public CacheStore(long expiryDuration, TimeUnit timeUnit) {
                 .build();
     }
 
-    // Obtener el valor directamente sin Mono
     public T get(String key) {
         T value = cache.getIfPresent(key);
         if (value != null) {
@@ -29,14 +28,12 @@ public T get(String key) {
         }
     }
 
-    // Eliminar un valor de la caché sin Mono
     public void delete(String key) {
         cache.invalidate(key);
     }
 
-    // Añadir un valor a la caché sin Mono
     public String add(String key, T value) {
-        if (key != null && !key.trim().isEmpty() && value != null) {
+        if (key != null && !key.isBlank() && value != null) {
             cache.put(key, value);
             return key;
         }

src/main/java/es/in2/vcverifier/config/ClientLoaderConfig.java

@@ -44,34 +44,34 @@ private List<RegisteredClient> loadClients() {
             // Convertir cada ClientData a RegisteredClient y agregarlo a la lista
             for (ClientData clientData : clientsData) {
                 RegisteredClient.Builder registeredClientBuilder = RegisteredClient.withId(UUID.randomUUID().toString())
-                        .clientId(clientData.getClientId())
-                        .clientAuthenticationMethods(authMethods -> clientData.getClientAuthenticationMethods().forEach(method ->
+                        .clientId(clientData.clientId())
+                        .clientAuthenticationMethods(authMethods -> clientData.clientAuthenticationMethods().forEach(method ->
                                 authMethods.add(new ClientAuthenticationMethod(method))))
-                        .authorizationGrantTypes(grantTypes -> clientData.getAuthorizationGrantTypes().forEach(grantType ->
+                        .authorizationGrantTypes(grantTypes -> clientData.authorizationGrantTypes().forEach(grantType ->
                                 grantTypes.add(new AuthorizationGrantType(grantType))))
-                        .redirectUris(uris -> uris.addAll(clientData.getRedirectUris()))
-                        .postLogoutRedirectUris(uris -> uris.addAll(clientData.getPostLogoutRedirectUris()))
-                        .scopes(scopes -> scopes.addAll(clientData.getScopes()));
+                        .redirectUris(uris -> uris.addAll(clientData.redirectUris()))
+                        .postLogoutRedirectUris(uris -> uris.addAll(clientData.postLogoutRedirectUris()))
+                        .scopes(scopes -> scopes.addAll(clientData.scopes()));
 
-                if (clientData.getClientSecret() != null && !clientData.getClientSecret().isEmpty()) {
-                    registeredClientBuilder.clientSecret(clientData.getClientSecret());
+                if (clientData.clientSecret() != null && !clientData.clientSecret().isBlank()) {
+                    registeredClientBuilder.clientSecret(clientData.clientSecret());
                 }
                 // Configurar ClientSettings
                 ClientSettings.Builder clientSettingsBuilder = ClientSettings.builder()
-                        .requireAuthorizationConsent(clientData.getRequireAuthorizationConsent());
+                        .requireAuthorizationConsent(clientData.requireAuthorizationConsent());
 
                 // Configurar valores opcionales si están presentes en el JSON
-                if (clientData.getJwkSetUrl() != null) {
-                    clientSettingsBuilder.jwkSetUrl(clientData.getJwkSetUrl());
+                if (clientData.jwkSetUrl() != null) {
+                    clientSettingsBuilder.jwkSetUrl(clientData.jwkSetUrl());
                 }
 
-                if (clientData.getTokenEndpointAuthenticationSigningAlgorithm() != null) {
+                if (clientData.tokenEndpointAuthenticationSigningAlgorithm() != null) {
                     clientSettingsBuilder.tokenEndpointAuthenticationSigningAlgorithm(
-                            SignatureAlgorithm.from(clientData.getTokenEndpointAuthenticationSigningAlgorithm()));
+                            SignatureAlgorithm.from(clientData.tokenEndpointAuthenticationSigningAlgorithm()));
                 }
 
-                if (clientData.getRequireProofKey() != null) {
-                    clientSettingsBuilder.requireProofKey(clientData.getRequireProofKey());
+                if (clientData.requireProofKey() != null) {
+                    clientSettingsBuilder.requireProofKey(clientData.requireProofKey());
                 }
 
 

src/main/java/es/in2/vcverifier/crypto/CryptoConfig.java

@@ -11,7 +11,7 @@ public class CryptoConfig {
 
     public String getPrivateKey() {
         String privateKey = cryptoProperties.privateKey();
-        if (privateKey.contains("0x")) {
+        if (privateKey.startsWith("0x")) {
             privateKey = privateKey.substring(2);
         }
         return privateKey;

src/main/java/es/in2/vcverifier/exception/CredentialException.java

@@ -0,0 +1,11 @@
+package es.in2.vcverifier.exception;
+
+public class CredentialException extends RuntimeException {
+    public CredentialException(String message) {
+        super(message);
+    }
+
+    public CredentialException(String message, Throwable cause) {
+        super(message, cause);
+    }
+}

src/main/java/es/in2/vcverifier/exception/CredentialMappingException.java

@@ -0,0 +1,9 @@
+package es.in2.vcverifier.exception;
+
+public class CredentialMappingException extends RuntimeException{
+
+    public CredentialMappingException(String message) {
+        super(message);
+    }
+
+}

src/main/java/es/in2/vcverifier/exception/IssuerOrParticipantIdException.java

@@ -0,0 +1,11 @@
+package es.in2.vcverifier.exception;
+
+public class IssuerOrParticipantIdException extends RuntimeException {
+    public IssuerOrParticipantIdException(String message) {
+        super(message);
+    }
+
+    public IssuerOrParticipantIdException(String message, Throwable cause) {
+        super(message, cause);
+    }
+}

src/main/java/es/in2/vcverifier/exception/JWTClaimMissingException.java

@@ -0,0 +1,9 @@
+package es.in2.vcverifier.exception;
+
+public class JWTClaimMissingException extends RuntimeException{
+
+    public JWTClaimMissingException(String message) {
+        super(message);
+    }
+
+}

src/main/java/es/in2/vcverifier/exception/JWTParsingException.java

@@ -0,0 +1,9 @@
+package es.in2.vcverifier.exception;
+
+public class JWTParsingException extends RuntimeException{
+
+    public JWTParsingException(String message) {
+        super(message);
+    }
+
+}

src/main/java/es/in2/vcverifier/exception/JsonConversionException.java

@@ -0,0 +1,9 @@
+package es.in2.vcverifier.exception;
+
+public class JsonConversionException extends RuntimeException{
+
+    public JsonConversionException(String message) {
+        super(message);
+    }
+
+}