i18n review (#60)

* update version

* feat: add translation of templates with defaultLang env variable

* tests

* remove logs

* update changelog

Author: rogermiretin2

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [v2.0.0](https://github.com/in2workspace/in2-verifier-api/releases/tag/v2.0.0)
+### Added
+- Get default language from configuration, use it to translate HTML templates.
+
 ## [v2.0.0](https://github.com/in2workspace/in2-verifier-api/releases/tag/v2.0.0)
 - New major version to align with the new major version of EUDIStack project.
 

build.gradle

@@ -10,7 +10,7 @@ plugins {
 }
 
 group = 'es.in2'
-version = '2.0.1'
+version = '2.0.2'
 
 java {
 	toolchain {

src/main/java/es/in2/vcverifier/config/FrontendConfig.java

@@ -46,6 +46,8 @@ public String getFaviconSrc() {
         return defaultIfBlank(properties.faviconSrc(), "dome_logo_favicon.png");
     }
 
+    public String getDefaultLang() { return defaultIfBlank(properties.defaultLang(), "en"); }
+
     private String defaultIfBlank(String value, String defaultValue) {
         return (value == null || value.trim().isEmpty()) ? defaultValue : value;
     }

src/main/java/es/in2/vcverifier/config/properties/FrontendProperties.java

@@ -13,7 +13,8 @@ public record FrontendProperties(
         @NotNull @NestedConfigurationProperty Urls urls,
         @NestedConfigurationProperty Colors colors,
         @NotBlank String logoSrc,
-        String faviconSrc) {
+        String faviconSrc,
+        String defaultLang) {
 
     public record Urls(
             @NotBlank @URL String onboarding,

src/main/java/es/in2/vcverifier/controller/ClientErrorController.java

@@ -35,7 +35,7 @@ public String showErrorPage(@RequestParam("errorCode") String errorCode,
         model.addAttribute("secondaryContrast", frontendConfig.getSecondaryContrastColor());
         model.addAttribute("faviconSrc", frontendConfig.getFaviconSrc());
         // Return the view name
-        return "client-authentication-error";
+        return "client-authentication-error-" + frontendConfig.getDefaultLang();
     }
 
 }

src/main/java/es/in2/vcverifier/controller/LoginQrController.java

@@ -49,7 +49,7 @@ public String showQrLogin(@RequestParam("authRequest") String authRequest, @Requ
         } catch (Exception e) {
             throw new QRCodeGenerationException(e.getMessage());
         }
-        return "login";
+        return "login-" + frontendConfig.getDefaultLang();
     }
 
     private String generateQRCodeImageBase64(String barcodeText) {

src/main/java/es/in2/vcverifier/service/TranslationService.java

@@ -0,0 +1,7 @@
+package es.in2.vcverifier.service;
+
+public interface TranslationService {
+    public String getLocale();
+    public String translate(String code, Object... args);
+}
+

src/main/java/es/in2/vcverifier/service/impl/TranslationServiceImpl.java

@@ -0,0 +1,53 @@
+package es.in2.vcverifier.service.impl;
+
+import es.in2.vcverifier.config.FrontendConfig;
+import es.in2.vcverifier.service.TranslationService;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.springframework.context.MessageSource;
+import org.springframework.context.NoSuchMessageException;
+import org.springframework.stereotype.Service;
+
+import java.util.List;
+import java.util.Locale;
+
+@Slf4j
+@Service
+@RequiredArgsConstructor
+public class TranslationServiceImpl implements TranslationService {
+
+    private final FrontendConfig frontendConfig;
+    private final MessageSource messageSource;
+
+    private static final List<String> SUPPORTED_LANGS = List.of("en", "es");
+
+    @Override
+    public String getLocale() {
+        String locale = frontendConfig.getDefaultLang();
+
+        if (locale == null || locale.isBlank()) {
+            log.warn("No default language configured. Using fallback: 'en'");
+            return "en";
+        }
+
+        locale = locale.trim().toLowerCase();
+
+        if (!SUPPORTED_LANGS.contains(locale)) {
+            log.warn("Unsupported language '{}'. Falling back to 'en'", locale);
+            return "en";
+        }
+        return locale;
+    }
+
+    @Override
+    public String translate(String code, Object... args) {
+        var locale = Locale.forLanguageTag(getLocale());
+        try {
+            return messageSource.getMessage(code, args, locale);
+        } catch (NoSuchMessageException e) {
+            log.warn("Message code '{}' not found for locale {}. Falling back to code.", code, locale);
+            return code;
+        }
+    }
+}
+

src/main/resources/application.yaml

@@ -74,6 +74,8 @@ verifier:
     logoSrc:
     # Placeholder for favicon source path (OPTIONAL)
     faviconSrc:
+    # Default language for visible texts (OPTIONAL)
+    defaultLang: en
   backend:
     # Placeholder for backend URL (REQUIRED)
     url: