Speed up space-check rules with O(1) line/character lookups#633
Open
williamthome wants to merge 1 commit into
Open
Speed up space-check rules with O(1) line/character lookups#633williamthome wants to merge 1 commit into
williamthome wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
operator_spaces,no_space, andno_space_after_poundfetched the source line and character withlists:nth/2(O(n)) and re-decoded the line on every token, which is O(tokens × lines) per file.lines_in/1now builds a per-line index once ({line, chars-tuple, length}), andcharacter_at_locationuseselement/2. No behaviour change;lists:nthleaves the profile's hot path.