Skip to content

Commit 42d8b3b

Browse files
authored
Merge pull request #3602 from inaturalist/android-save-match-crash
Android save match crash
2 parents 9057607 + ed8d28c commit 42d8b3b

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

src/sharedHelpers/saveObservation.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ import * as Exify from "@lodev09/react-native-exify";
33
import type Realm from "realm";
44
import Observation from "realmModels/Observation";
55
import type { RealmObservation } from "realmModels/types";
6+
import { log } from "sharedHelpers/logger";
7+
8+
const logger = log.extend( "saveObservation.ts" );
69

710
const writeExifToCameraRollPhotos = async (
811
observation: RealmObservation,
@@ -28,9 +31,12 @@ const writeExifToCameraRollPhotos = async (
2831
};
2932

3033
// Update all photos taken via the app with the new fetched location.
31-
cameraRollUris.forEach( uri => {
32-
Exify.write( uri, exifToWrite );
33-
} );
34+
const results = await Promise.allSettled(
35+
cameraRollUris.map( uri => Exify.write( uri, exifToWrite ) ),
36+
);
37+
results
38+
.filter( ( r ): r is PromiseRejectedResult => r.status === "rejected" )
39+
.forEach( r => logger.error( "Failed to write EXIF to camera roll photo:", r.reason ) );
3440
};
3541

3642
const saveObservation = async (

0 commit comments

Comments
 (0)