IWF-1174: add logging for S3 & local activity errors#599
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (23.44%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
- Coverage 65.70% 64.77% -0.93%
==========================================
Files 64 64
Lines 6461 6592 +131
==========================================
+ Hits 4245 4270 +25
- Misses 1893 1995 +102
- Partials 323 327 +4
🚀 New features to boost your workflow:
|
service/interpreter/activityImpl.go
Outdated
| if err != nil { | ||
| if activityInfo.IsLocalActivity { | ||
| reqBytes, _ := json.Marshal(input.Request) | ||
| logger.Info("StateApiWaitUntil local activity return on error", |
There was a problem hiding this comment.
should it be Warn or Error?
There was a problem hiding this comment.
👋
Warn would probably be better. Teams are having trouble understanding why local activity fails and most of the time it's failing due to payload size.
There was a problem hiding this comment.
You should push Temporal to fix their history model: temporalio/temporal#4389
temporalio/temporal#5310 so that iWF can get rid of Local Activity
|
lgtm |
|
also looks good to me! |
longquanzheng
left a comment
longquanzheng
left a comment
There was a problem hiding this comment.
There will be tons of logs . It will be better to enable with a config instead.
4 participants
Description
Checklist
Related Issue
Closes #issue_number