Skip to content

Commit 659c868

Browse files
committed
No need to iterate over the categories if the user isn't tracking them
1 parent cca0992 commit 659c868

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

outlook/indico_outlook/plugin.py

+8-7
Original file line numberDiff line numberDiff line change
@@ -318,13 +318,14 @@ def event_updated(self, event, changes, **kwargs):
318318
if self._user_tracks_favorite_events(user):
319319
users_to_update.add(user)
320320

321-
for category in reversed(event.category.chain_query.all()):
322-
for user in category.favorite_of:
323-
if self._user_tracks_favorite_categories(user) and event.can_access(user):
324-
users_to_update.add(user)
325-
# Stop once we reach the visibility horizon of the event
326-
if category is event.category.real_visibility_horizon:
327-
break
321+
if self._user_tracks_favorite_categories(user):
322+
for category in reversed(event.category.chain_query.all()):
323+
for user in category.favorite_of:
324+
if event.can_access(user):
325+
users_to_update.add(user)
326+
# Stop once we reach the visibility horizon of the event
327+
if category is event.category.real_visibility_horizon:
328+
break
328329

329330
for user in users_to_update:
330331
self.logger.info('Event data change: updating %s in %r', user, event)

0 commit comments

Comments
 (0)