Driver for Wanderer Cover V4 Pro-EC added and known issue for V4-EC driver fixed. (#2267)

* Driver for Wanderer Eclipse added.

* Driver for Wanderer Eclipse added.

* Driver for Wanderer Eclipse added.

* Driver for Wanderer Cover V4 Pro-EC added, and known issue fixed.

---------

Co-authored-by: WandererAstro <skywatcherwsl2000@gmail.com>

Author: WandererAstro

drivers.xml

@@ -843,6 +843,10 @@
             <driver name="WandererCover V4-EC">indi_wanderercover_v4_ec</driver>
             <version>1.2</version>
         </device>
+        <device label="WandererCover V4 Pro-EC" manufacturer="Wanderer Astro">
+            <driver name="WandererCover V4 Pro-EC">indi_wanderercover_v4_pro_ec</driver>
+            <version>1.0</version>
+        </device>
         <device label="Wanderer Eclipse" manufacturer="Wanderer Astro">
             <driver name="Wanderer Eclipse">indi_wanderer_eclipse</driver>
             <version>1.2</version>

drivers/auxiliary/CMakeLists.txt

@@ -25,6 +25,14 @@ add_executable(indi_wanderercover_v4_ec ${indi_wanderercover_v4_ec_SRC})
 target_link_libraries(indi_wanderercover_v4_ec indidriver)
 install(TARGETS indi_wanderercover_v4_ec RUNTIME DESTINATION bin)
 
+# ########## WandererCover V4 Pro-EC###############
+SET(indi_wanderercover_v4_pro_ec_SRC
+    wanderer_cover_v4_pro_ec.cpp)
+
+add_executable(indi_wanderercover_v4_pro_ec ${indi_wanderercover_v4_pro_ec_SRC})
+target_link_libraries(indi_wanderercover_v4_pro_ec indidriver)
+install(TARGETS indi_wanderercover_v4_pro_ec RUNTIME DESTINATION bin)
+
 # ########## Wanderer Eclipse###############
 SET(indi_wanderer_eclipse_SRC
     wanderer_eclipse.cpp)

drivers/auxiliary/wanderer_cover_v4_ec.cpp

@@ -175,7 +175,7 @@ bool WandererCoverLegacyProtocol::parseDeviceData(const char* data, WandererCove
         device->statusData.voltage = device->voltageread;
 
         // Update the UI with the parsed data
-        device->updateData(device->closesetread, device->opensetread, device->positionread, device->voltageread);
+        device->updateData(device->closesetread, device->opensetread, device->positionread, device->voltageread,device->flatpanelbrightnessread, device->dewheaterpowerread,device->asiaircontrolenabledread);
 
         // Update the Close and Open position settings with the values from the device
         device->CloseSetNP[device->CloseSet].setValue(device->closesetread);
@@ -305,9 +305,12 @@ bool WandererCoverModernProtocol::parseDeviceData(const char* data, WandererCove
         // Parse extended data for modern protocol
         if (tokens.size() >= 8)
         {
-            device->statusData.flatPanelBrightness = std::atoi(tokens[6].c_str());
-            device->statusData.dewHeaterPower = std::atoi(tokens[7].c_str());
-            device->statusData.asiairControlEnabled = (tokens.size() > 8) ? (std::atoi(tokens[8].c_str()) == 1) : false;
+            device->flatpanelbrightnessread = std::atoi(tokens[6].c_str());
+            device->statusData.flatPanelBrightness = device->flatpanelbrightnessread;
+            device->dewheaterpowerread = std::atoi(tokens[7].c_str());
+            device->statusData.dewHeaterPower = device->dewheaterpowerread;
+            device->asiaircontrolenabledread = (tokens.size() > 8) ? (std::atoi(tokens[8].c_str()) == 1) : false;
+            device->statusData.asiairControlEnabled = device->asiaircontrolenabledread;
         }
 
         // Update status data
@@ -318,7 +321,7 @@ bool WandererCoverModernProtocol::parseDeviceData(const char* data, WandererCove
         device->statusData.voltage = device->voltageread;
 
         // Update the UI with the parsed data
-        device->updateData(device->closesetread, device->opensetread, device->positionread, device->voltageread);
+        device->updateData(device->closesetread, device->opensetread, device->positionread, device->voltageread,device->flatpanelbrightnessread, device->dewheaterpowerread,device->asiaircontrolenabledread);
 
         // Update the Close and Open position settings with the values from the device
         device->CloseSetNP[device->CloseSet].setValue(device->closesetread);
@@ -381,10 +384,9 @@ bool WandererCoverV4EC::initProperties()
     DataNP[openset_read].fill( "Open_Position", "Open Position Set(°)", "%4.2f", 0, 999, 100, 0);
     DataNP[position_read].fill( "Current_Position", "Current Position(°)", "%4.2f", 0, 999, 100, 0);
     DataNP[voltage_read].fill( "Voltage", "Voltage (V)", "%4.2f", 0, 999, 100, 0);
-    DataNP[flat_panel_brightness_read].fill( "Flat_Panel_Brightness", "Flat Panel Brightness", "%d", 0, 255, 1, 0);
-    DataNP[dew_heater_power_read].fill( "Dew_Heater_Power", "Dew Heater Power", "%d", 0, 150, 1, 0);
-    DataNP[asiair_control_enabled_read].fill( "ASIAIR_Control_Enabled", "ASIAIR Control Enabled", "%d", 0, 1, 1, 0);
-    DataNP[firmware_version_read].fill( "Firmware_Version", "Firmware Version", "%d", 0, 99999999, 1, 0);
+    DataNP[flat_panel_brightness_read].fill( "Flat_Panel_Brightness", "Flat Panel Brightness", "%4.2f", 0, 255, 1, 0);
+    DataNP[dew_heater_power_read].fill( "Dew_Heater_Power", "Dew Heater Power", "%4.2f", 0, 150, 1, 0);
+    DataNP[asiair_control_enabled_read].fill( "ASIAIR_Control_Enabled", "ASIAIR Control Enabled", "%4.2f", 0, 1, 1, 0);
     DataNP.fill(getDeviceName(), "STATUS", "Real Time Status", MAIN_CONTROL_TAB, IP_RO, 60, IPS_IDLE);
 
     // Firmware information
@@ -411,9 +413,9 @@ bool WandererCoverV4EC::initProperties()
     ASIAIRControlSP[ASIAIR_DISABLE].fill("ASIAIR_DISABLE", "Disable ASIAIR Control", ISS_ON);
     ASIAIRControlSP.fill(getDeviceName(), "ASIAIR_CONTROL", "ASIAIR Control", MAIN_CONTROL_TAB, IP_RW, ISR_1OFMANY, 60, IPS_IDLE);
 
-    CustomBrightnessNP[CUSTOM_BRIGHTNESS_1].fill("CUSTOM_BRIGHTNESS_1", "Custom Brightness 1", "%d", 0, 255, 1, 100);
-    CustomBrightnessNP[CUSTOM_BRIGHTNESS_2].fill("CUSTOM_BRIGHTNESS_2", "Custom Brightness 2", "%d", 0, 255, 1, 100);
-    CustomBrightnessNP[CUSTOM_BRIGHTNESS_3].fill("CUSTOM_BRIGHTNESS_3", "Custom Brightness 3", "%d", 0, 255, 1, 100);
+    CustomBrightnessNP[CUSTOM_BRIGHTNESS_1].fill("CUSTOM_BRIGHTNESS_1", "Custom Brightness 1", "%1.0f", 0, 255, 1, 1);
+    CustomBrightnessNP[CUSTOM_BRIGHTNESS_2].fill("CUSTOM_BRIGHTNESS_2", "Custom Brightness 2", "%1.0f", 0, 255, 1, 50);
+    CustomBrightnessNP[CUSTOM_BRIGHTNESS_3].fill("CUSTOM_BRIGHTNESS_3", "Custom Brightness 3", "%1.0f", 0, 255, 1, 255);
     CustomBrightnessNP.fill(getDeviceName(), "CUSTOM_BRIGHTNESS", "Custom Brightness", MAIN_CONTROL_TAB, IP_RW, 60, IPS_IDLE);
 
     AutoDetectSP[AUTO_DETECT_OPEN].fill("AUTO_DETECT_OPEN", "Auto Detect Open Position", ISS_OFF);
@@ -447,15 +449,6 @@ bool WandererCoverV4EC::updateProperties()
         snprintf(firmwareStr, sizeof(firmwareStr), "%d", firmware);
         FirmwareTP[FIRMWARE_VERSION].setText(firmwareStr);
 
-        if(firmware >= 20240101)
-        {
-            LOGF_INFO("Firmware version: %d", firmware);
-        }
-        else
-        {
-            LOGF_INFO("Firmware version: %d", firmware);
-            LOG_INFO("New firmware available!");
-        }
 
         // Update the Close and Open position settings with the values from the device
         CloseSetNP[CloseSet].setValue(closesetread);
@@ -612,17 +605,11 @@ bool WandererCoverV4EC::detectProtocol()
             LOG_INFO("WandererCover V4-EC device detected");
         }
         // Check for similar devices that might be compatible
-        else if (deviceName == "ZXWBProV3" || deviceName == "ZXWBPlusV3" || 
-                 deviceName == "UltimateV2" || deviceName == "PlusV2")
+	else if (deviceName == "ZXWBProV3" || deviceName == "ZXWBPlusV3" || 
+                deviceName == "UltimateV2" || deviceName == "PlusV2"|| deviceName == "WandererEclipse"|| deviceName == "WandererDewTerminator"|| deviceName == "WandererCoverV4Pro")
         {
-            LOGF_WARN("Detected similar device: '%s'. This driver is designed for WandererCover V4-EC.", deviceName.c_str());
-            LOG_WARN("Compatibility not guaranteed. Proceeding with caution...");
-        }
-        // Check for partial matches (in case of data corruption or incomplete transmission)
-        else if (deviceName.find("WandererCover") != std::string::npos)
-        {
-            LOGF_WARN("Partial device match detected: '%s'. Expected 'WandererCoverV4'", deviceName.c_str());
-            LOG_WARN("Proceeding with partial match...");
+            LOGF_ERROR("WandererAstro products detected, but the model does not match: '%s'. This driver is designed for WandererCover V4-EC only, please choose the right driver or try another serial port!", deviceName.c_str());
+            return false;
         }
         else
         {
@@ -647,14 +634,14 @@ bool WandererCoverV4EC::detectProtocol()
         {
             std::unique_ptr<WandererCoverModernProtocol> modernProtocol = std::make_unique<WandererCoverModernProtocol>();
             setProtocol(std::move(modernProtocol));
-            LOG_INFO("Using modern protocol (firmware >= 20250404)");
+            LOG_INFO("Using modern protocol (firmware >= 20250404) Please note that in the newer firmware, to protect dark conditions, the flat light will remain off whenever the Cover is open.");
             return true;
         }
         else if (firmwareVersion > 0)
         {
             std::unique_ptr<WandererCoverLegacyProtocol> legacyProtocol = std::make_unique<WandererCoverLegacyProtocol>();
             setProtocol(std::move(legacyProtocol));
-            LOG_INFO("Using legacy protocol (firmware < 20250404)");
+            LOG_INFO("Using legacy protocol (firmware < 20250404) Firmware update recommended.");
             return true;
         }
         else
@@ -673,7 +660,7 @@ bool WandererCoverV4EC::detectProtocol()
 void WandererCoverV4EC::setProtocol(std::unique_ptr<IWandererCoverProtocol> protocol)
 {
     currentProtocol = std::move(protocol);
-    LOGF_INFO("Protocol set to: %s", currentProtocol->getProtocolName().c_str());
+    
 }
 
 ////////////////////////////////////////////////////////////////////////////////////////////////////////
@@ -748,7 +735,7 @@ bool WandererCoverV4EC::parseDeviceData(const char *data)
 ////////////////////////////////////////////////////////////////////////////////////////////////////////
 ///
 ////////////////////////////////////////////////////////////////////////////////////////////////////////
-void WandererCoverV4EC::updateData(double closesetread, double opensetread, double positionread, double voltageread)
+void WandererCoverV4EC::updateData(double closesetread, double opensetread, double positionread, double voltageread,double flatpanelbrightnessread,double dewheaterpowerread, double asiaircontrolenabledread)
 {
     // Update basic data
     DataNP[closeset_read].setValue(closesetread);
@@ -759,18 +746,16 @@ void WandererCoverV4EC::updateData(double closesetread, double opensetread, doub
     // Update extended data only if supported by current protocol
     if (currentProtocol && currentProtocol->supportsFeature("extended_status"))
     {
-        DataNP[flat_panel_brightness_read].setValue(statusData.flatPanelBrightness);
-        DataNP[dew_heater_power_read].setValue(statusData.dewHeaterPower);
-        DataNP[asiair_control_enabled_read].setValue(statusData.asiairControlEnabled ? 1 : 0);
-        DataNP[firmware_version_read].setValue(statusData.firmware);
+        DataNP[flat_panel_brightness_read].setValue(flatpanelbrightnessread);
+        DataNP[dew_heater_power_read].setValue(dewheaterpowerread);
+        DataNP[asiair_control_enabled_read].setValue(asiaircontrolenabledread);
     }
     else
     {
         // For legacy protocol, set default values for unsupported features
         DataNP[flat_panel_brightness_read].setValue(-1);
         DataNP[dew_heater_power_read].setValue(-1);
         DataNP[asiair_control_enabled_read].setValue(-1);
-        DataNP[firmware_version_read].setValue(-1);
     }
 
     DataNP.setState(IPS_OK);

drivers/auxiliary/wanderer_cover_v4_ec.h

@@ -177,10 +177,13 @@ class WandererCoverV4EC : public INDI::DefaultDevice, public INDI::DustCapInterf
     double opensetread=0;
     double positionread=0;
     double voltageread=0;
+    double dewheaterpowerread=0;
+    double asiaircontrolenabledread=0;
+    double flatpanelbrightnessread=0;
     bool setDewPWM(int id, int value);
     bool setClose(double value);
     bool setOpen(double value);
-    void updateData(double closesetread,double opensetread,double positionread,double voltageread);
+    void updateData(double closesetread,double opensetread,double positionread,double voltageread,double flatpanelbrightnessread,double dewheaterpowerread,double asiaircontrolenabledread);
 
     // Protocol detection and management
     bool detectProtocol();
@@ -194,7 +197,7 @@ class WandererCoverV4EC : public INDI::DefaultDevice, public INDI::DustCapInterf
     IWandererCoverProtocol::StatusData statusData;
 
     // Properties for all protocol versions
-    INDI::PropertyNumber DataNP{8}; // Extended to support new protocol fields
+    INDI::PropertyNumber DataNP{7}; // Extended to support new protocol fields
     enum
     {
         closeset_read,
@@ -204,7 +207,6 @@ class WandererCoverV4EC : public INDI::DefaultDevice, public INDI::DustCapInterf
         flat_panel_brightness_read,
         dew_heater_power_read,
         asiair_control_enabled_read,
-        firmware_version_read,
     };
 
     //Dew heater///////////////////////////////////////////////////////////////