Ensure configuration is saved to file. Any property that uses saveConfig should have an equivelant Property.save(fp) in saveConfigItems

Author: knro

drivers.xml

@@ -1101,7 +1101,7 @@
         </device>
         <device label="Pegasus PPBA" manufacturer="Pegasus Astro">
             <driver name="Pegasus PPBA">indi_pegasus_ppba</driver>
-            <version>1.3</version>
+            <version>1.4</version>
         </device>
         <device label="Pegasus PPBM" manufacturer="Pegasus Astro">
             <driver name="Pegasus PPBM">indi_pegasus_ppba</driver>

drivers/power/pegasus_ppb.cpp

@@ -219,7 +219,7 @@ bool PegasusPPB::ISNewSwitch(const char * dev, const char * name, ISState * stat
             PowerOnBootSP.update(states, names, n);
             PowerOnBootSP.setState(setPowerOnBoot() ? IPS_OK : IPS_ALERT);
             PowerOnBootSP.apply();
-            saveConfig(true, PowerOnBootSP.getName());
+            saveConfig(PowerOnBootSP);
             return true;
         }
 
@@ -351,6 +351,9 @@ bool PegasusPPB::setDewPWM(uint8_t id, uint8_t value)
 bool PegasusPPB::saveConfigItems(FILE * fp)
 {
     INDI::DefaultDevice::saveConfigItems(fp);
+
+    PowerOnBootSP.save(fp);
+
     WI::saveConfigItems(fp);
     PI::saveConfigItems(fp);
 
@@ -405,7 +408,7 @@ bool PegasusPPB::getSensorData()
                 PI::PowerSensorsNP[PI::SENSOR_CURRENT].setValue(std::stod(result[PA_CURRENT]) / 65.0);
                 PI::PowerSensorsNP.setState(IPS_OK);
                 if (lastSensorData.size() > PA_CURRENT &&
-                    (lastSensorData[PA_VOLTAGE] != result[PA_VOLTAGE] || lastSensorData[PA_CURRENT] != result[PA_CURRENT]))
+                        (lastSensorData[PA_VOLTAGE] != result[PA_VOLTAGE] || lastSensorData[PA_CURRENT] != result[PA_CURRENT]))
                     PI::PowerSensorsNP.apply();
             }
 
@@ -416,9 +419,9 @@ bool PegasusPPB::getSensorData()
                 setParameterValue("WEATHER_HUMIDITY", std::stod(result[PA_HUMIDITY]));
                 setParameterValue("WEATHER_DEWPOINT", std::stod(result[PA_DEW_POINT]));
                 if (lastSensorData.size() > PA_DEW_POINT &&
-                    (lastSensorData[PA_TEMPERATURE] != result[PA_TEMPERATURE] ||
-                     lastSensorData[PA_HUMIDITY] != result[PA_HUMIDITY] ||
-                     lastSensorData[PA_DEW_POINT] != result[PA_DEW_POINT]))
+                        (lastSensorData[PA_TEMPERATURE] != result[PA_TEMPERATURE] ||
+                         lastSensorData[PA_HUMIDITY] != result[PA_HUMIDITY] ||
+                         lastSensorData[PA_DEW_POINT] != result[PA_DEW_POINT]))
                 {
                     if (WI::syncCriticalParameters())
                         critialParametersLP.apply();
@@ -458,7 +461,7 @@ bool PegasusPPB::getSensorData()
                 if (PI::DewChannelDutyCycleNP.size() >= 2)
                     PI::DewChannelDutyCycleNP[1].setValue(std::stod(result[PA_DEW_2]) / 255.0 * 100.0);
                 if (lastSensorData.size() > PA_DEW_2 &&
-                    (lastSensorData[PA_DEW_1] != result[PA_DEW_1] || lastSensorData[PA_DEW_2] != result[PA_DEW_2]))
+                        (lastSensorData[PA_DEW_1] != result[PA_DEW_1] || lastSensorData[PA_DEW_2] != result[PA_DEW_2]))
                     PI::DewChannelDutyCycleNP.apply();
             }
 

drivers/power/pegasus_ppba.cpp

@@ -36,7 +36,7 @@ static std::unique_ptr<PegasusPPBA> ppba(new PegasusPPBA());
 
 PegasusPPBA::PegasusPPBA() : INDI::DefaultDevice(), FI(this), WI(this), PI(this)
 {
-    setVersion(1, 3);
+    setVersion(1, 4);
     lastSensorData.reserve(PA_N);
     lastConsumptionData.reserve(PS_N);
     lastMetricsData.reserve(PC_N);
@@ -407,7 +407,7 @@ bool PegasusPPBA::ISNewSwitch(const char * dev, const char * name, ISState * sta
             PowerOnBootSP.update(states, names, n);
             PowerOnBootSP.setState(setPowerOnBoot() ? IPS_OK : IPS_ALERT);
             PowerOnBootSP.apply();
-            saveConfig(true, PowerOnBootSP.getName());
+            saveConfig(PowerOnBootSP);
             return true;
         }
 
@@ -630,15 +630,21 @@ bool PegasusPPBA::setDewPWM(uint8_t id, uint8_t value)
 bool PegasusPPBA::saveConfigItems(FILE * fp)
 {
     INDI::DefaultDevice::saveConfigItems(fp);
+
+    AdjOutVoltSP.save(fp);
+    PowerOnBootSP.save(fp);
+    AutoDewSettingsNP.save(fp);
+
     if (m_HasExternalMotor)
     {
         FI::saveConfigItems(fp);
         FocuserSettingsNP.save(fp);
         FocuserDriveSP.save(fp);
     }
+
     WI::saveConfigItems(fp);
-    PI::saveConfigItems(fp); // Save power properties
-    AutoDewSettingsNP.save(fp); // This is a custom property, not part of INDI::PowerInterface
+    PI::saveConfigItems(fp);
+
     return true;
 }
 

drivers/power/pegasus_upb.cpp

@@ -816,6 +816,7 @@ bool PegasusUPB::saveConfigItems(FILE * fp)
         AutoDewAggNP.save(fp);
     }
     FocuserSettingsNP.save(fp);
+    PowerOnBootSP.save(fp);
     return true;
 }