Merge pull request #9 from indix/rsyslog_multi_file_support

Template changes to support multiple files through rsyslog and fixed …

Author: ashwanthkumar

glide.lock

@@ -1,12 +1,22 @@
 package mesos
 
-import "errors"
+import (
+	"errors"
+	"github.com/parnurzeal/gorequest"
+)
 
 type Mesos interface {
 	SlaveState(slaveHost string) (SlaveState, error)
 }
 
-type MesosClient struct {
+type mesosClient struct {
+	Request *gorequest.SuperAgent
+}
+
+func NewMesosClient() Mesos {
+	client := new(mesosClient)
+	client.Request = gorequest.New()
+	return client
 }
 
 func combineErrors(errs []error) error {

mesos/client.go

@@ -3,8 +3,6 @@ package mesos
 import (
 	"encoding/json"
 	"time"
-
-	"github.com/parnurzeal/gorequest"
 )
 
 type SlaveState struct {
@@ -36,9 +34,9 @@ type Executor struct {
 	Source    string `json:"source"`
 }
 
-func (m *MesosClient) SlaveState(slaveHost string) (SlaveState, error) {
-	request := gorequest.New()
-	response, body, errs := request.
+
+func (m *mesosClient) SlaveState(slaveHost string) (SlaveState, error) {
+	response, body, errs := m.Request.
 		Get(slaveHost).
 		Timeout(10 * time.Minute).
 		End()

mesos/slaves.go

@@ -19,15 +19,16 @@ const RsyslogTemplate = `
 # Created via marathon-logger,
 # PLEASE DON'T EDIT THIS FILE MANUALLY
 # Name - {{ .App }}
-# File - {{ .FileName }}
+# File - {{ .FileNames }}
 ######################################
 
 module(load="imfile")
-
+{{range $fileName := .FileNames}}
 input(type="imfile"
-	File="{{ .WorkDir }}/{{ .FileName }}"
-	Tag="{{ .CleanAppName }}	{{.TaskID}}"
+	File="{{ $.WorkDir }}/{{$fileName}}"
+	Tag="{{$.CleanAppName}}	{{$.TaskID}}	{{$fileName}}"
 	Severity="info")
+{{end}}
 `
 
 // Rsyslog backend implementation

rsyslog-logger.go

@@ -22,23 +22,68 @@ func TestRenderRsyslogTemplate(t *testing.T) {
 		Labels:   label,
 		TaskID:   "abcdefghij",
 		CWD:      "/foo/bar",
-		FileName: "test_file_name.txt",
+		FileNames: []string{"test_file_name.txt"},
 	}
 
 	expected := `
 ######################################
 # Created via marathon-logger,
 # PLEASE DON'T EDIT THIS FILE MANUALLY
 # Name - /test.aayush.http
-# File - test_file_name.txt
+# File - [test_file_name.txt]
 ######################################
 
 module(load="imfile")
 
 input(type="imfile"
 	File="/foo/bar/abcdefghij/test_file_name.txt"
-	Tag="test.aayush.http	abcdefghij"
+	Tag="test.aayush.http	abcdefghij	test_file_name.txt"
 	Severity="info")
+
+`
+	template, err := rsyslog.render(taskInfo)
+	assert.NoError(t, err)
+	assert.Equal(t, expected, template)
+}
+
+func TestRenderRsyslogTemplateForMultipleFiles(t *testing.T) {
+
+	hostname, err := os.Hostname()
+	var rsyslog = Rsyslog{
+		WorkDir: "/foo/bar",
+	}
+	label := map[string]string{
+		"logs.enabled": "true",
+	}
+	taskInfo := TaskInfo{
+		App:      "/test.aayush.http",
+		Hostname: hostname,
+		Labels:   label,
+		TaskID:   "abcdefghij",
+		CWD:      "/foo/bar",
+		FileNames: []string{"test_file_name1.txt","test_file_name2.txt"},
+	}
+
+	expected := `
+######################################
+# Created via marathon-logger,
+# PLEASE DON'T EDIT THIS FILE MANUALLY
+# Name - /test.aayush.http
+# File - [test_file_name1.txt test_file_name2.txt]
+######################################
+
+module(load="imfile")
+
+input(type="imfile"
+	File="/foo/bar/abcdefghij/test_file_name1.txt"
+	Tag="test.aayush.http	abcdefghij	test_file_name1.txt"
+	Severity="info")
+
+input(type="imfile"
+	File="/foo/bar/abcdefghij/test_file_name2.txt"
+	Tag="test.aayush.http	abcdefghij	test_file_name2.txt"
+	Severity="info")
+
 `
 	template, err := rsyslog.render(taskInfo)
 	assert.NoError(t, err)

rsyslog-logger_test.go

@@ -15,13 +15,13 @@ import (
 const LogFilesToMonitor = "logs.files"
 
 type TaskInfo struct {
-	App      string
-	Labels   map[string]string
-	TaskID   string
-	Hostname string
-	CWD      string // Current working directory of the task in the slave
-	FileName string // Actual file name to that we need monitor for logs
-	WorkDir  string // WorkDir location of marathon-logger where we setup Symlink
+	App       string
+	Labels    map[string]string
+	TaskID    string
+	Hostname  string
+	CWD       string // Current working directory of the task in the slave
+	FileNames []string // Actual file name to that we need monitor for logs
+	WorkDir   string // WorkDir location of marathon-logger where we setup Symlink
 }
 
 // CleanAppName cleans the app-name string for `/` characters
@@ -54,7 +54,7 @@ func (t *TaskManager) Start() {
 	t.AddLogs = make(chan TaskInfo)
 	t.RemoveLogs = make(chan string)
 	t.KnownTasks = make(map[string]time.Time)
-	t.Client = &mesos.MesosClient{}
+	t.Client = mesos.NewMesosClient()
 	go t.run()
 	fmt.Println("Task Manager Started.")
 	fmt.Printf("Task Manager - Task's MaxHeartBeatInterval is %v\n", t.MaxTasksHeartBeatInterval)
@@ -101,18 +101,16 @@ func (t *TaskManager) run() {
 				if executor != nil {
 					logFiles := strings.Split(maps.GetString(task.Labels, LogFilesToMonitor, "stdout"), ",")
 					t.KnownTasks[task.TaskID] = time.Now()
-					for _, file := range logFiles {
-						taskInfo := TaskInfo{
-							App:      task.App,
-							Hostname: task.Hostname,
-							Labels:   task.Labels,
-							TaskID:   task.TaskID,
-							CWD:      executor.Directory,
-							FileName: file,
-						}
-						// fmt.Printf("%v\n", taskInfo)
-						t.AddLogs <- taskInfo
+					taskInfo := TaskInfo{
+						App:      task.App,
+						Hostname: task.Hostname,
+						Labels:   task.Labels,
+						TaskID:   task.TaskID,
+						CWD:      executor.Directory,
+						FileNames: logFiles,
 					}
+					// fmt.Printf("%v\n", taskInfo)
+					t.AddLogs <- taskInfo
 				} else {
 					log.Printf("[WARN] Couldn't find the executor that spun up the task %s", task.TaskID)
 				}