url change, new endpoint to plant_list and more timespan options #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indykoning
reviewed
Aug 9, 2023
| else: | ||
| elif timespan == Timespan.day or timespan == Timespan.hour: | ||
| date_str = date.strftime('%Y-%m-%d') | ||
| else: |
Owner
There was a problem hiding this comment.
Could you reorder the if statement to have %Y at the top, %Y-%m after the and %Y-%m-%d at the bottom? Helps with reading through the code faster 🙂
|
|
||
| class GrowattApi: | ||
| server_url = 'https://server-api.growatt.com/' | ||
| server_url = 'https://server.growatt.com/' |
Owner
There was a problem hiding this comment.
server-api.growatt.com is still the URL being used by the app, as not everyone is having issues with the current URL and the new URL might respond differently.
It could cause issues in currently running code.
It's best to overwrite this URL in the scripts using it
Suggested change
| server_url = 'https://server.growatt.com/' | |
| server_url = 'https://server-api.growatt.com/' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server_url change, same as pr #62
endpoint for plant_detail changed from
PlantDetailAPItonewPlantDetailAPI, retrieving complete date on data dictadded 2 more timespan options,
yearandall