Added timeout for each requests #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests without timeout goes into infinity wait which blocks forever the caller. Timeout helps for interrupting these calls and handling as an error.
Owner
|
Sorry for the long wait, i like the idea! |
Author
|
@indykoning I do not know, I guess it ups on the user. In my case the problem was that in case of the server is not accessible stayed there forever and I could not exit from this wait on a normal way. |
Contributor
|
@nagycsongor can you also add the timeout to the new merged Noah Requests? I am at the holidays at the moment. @indykoning I would say a default Timeout like 30 seconds, but the user can also configure a custom timeout. I think for 90% of the Users a default is fine like all the HomeAssistant Users that don't know that the integration is based on your project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests without timeout goes into infinity wait
which blocks forever the caller. Timeout helps for interrupting these calls and handling as an error.