omit meta from history

joetannenbaum · joetannenbaum · commit 143b34468514 · 2024-07-11T22:42:51.000-04:00
diff --git a/packages/core/src/history.ts b/packages/core/src/history.ts
@@ -21,11 +21,17 @@ export class History {
   }
 
   public static pushState(page: Page): void {
-    window.history.pushState(page, '', page.url)
+    window.history.pushState(this.pageData(page), '', page.url)
   }
 
   public static replaceState(page: Page): void {
-    window.history.replaceState(page, '', page.url)
+    window.history.replaceState(this.pageData(page), '', page.url)
+  }
+
+  protected static pageData(page: Page): Omit<Page, 'meta'> {
+    const { meta, ...remaining } = page
+
+    return remaining
   }
 
   public static setState(key: string, value: any) {

Original file line number	Diff line number	Diff line change
`@@ -21,11 +21,17 @@ export class History {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`public static pushState(page: Page): void {`
`24`		`- window.history.pushState(page, '', page.url)`
	`24`	`+ window.history.pushState(this.pageData(page), '', page.url)`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`public static replaceState(page: Page): void {`
`28`		`- window.history.replaceState(page, '', page.url)`
	`28`	`+ window.history.replaceState(this.pageData(page), '', page.url)`
	`29`	`+ }`
	`30`	`+`
	`31`	`+ protected static pageData(page: Page): Omit<Page, 'meta'> {`
	`32`	`+ const { meta, ...remaining } = page`
	`33`	`+`
	`34`	`+ return remaining`
`29`	`35`	`}`
`30`	`36`
`31`	`37`	`public static setState(key: string, value: any) {`