Commit 0c7b522
committed
rlc: remove a dead member and three leftover TODO comments
NrRlcAmTxEntity declared txNextAck_ and never used it -- clang reported it as
-Wunused-private-field. The transmission window's real txNextAck_ lives in
RlcSduSlidingWindowTransmissionBuffer, which the entity delegates to.
The other three are comments: two "TODO Auto-generated destructor stub" lines
left behind by the IDE that created the NR PDU classes, and a note in
RlcUmReceptionBuffer::handleSegment speculating that the window-advance path
may leak SDU pointers. It does not -- discardOutsideWindow(), called just
above it, deletes the sduPointer of every entry it drops before erasing it.1 parent c905a7a commit 0c7b522
4 files changed
Lines changed: 0 additions & 4 deletions
File tree
- src/simu5g/stack/rlc
- am
- packet
- um
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | 51 | | |
53 | 52 | | |
54 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
87 | 86 | | |
88 | 87 | | |
89 | 88 | | |
| |||
0 commit comments