Skip to content

Commit 0c7b522

Browse files
committed
rlc: remove a dead member and three leftover TODO comments
NrRlcAmTxEntity declared txNextAck_ and never used it -- clang reported it as -Wunused-private-field. The transmission window's real txNextAck_ lives in RlcSduSlidingWindowTransmissionBuffer, which the entity delegates to. The other three are comments: two "TODO Auto-generated destructor stub" lines left behind by the IDE that created the NR PDU classes, and a note in RlcUmReceptionBuffer::handleSegment speculating that the window-advance path may leak SDU pointers. It does not -- discardOutsideWindow(), called just above it, deletes the sduPointer of every entry it drops before erasing it.
1 parent c905a7a commit 0c7b522

4 files changed

Lines changed: 0 additions & 4 deletions

File tree

src/simu5g/stack/rlc/am/NrRlcAmTxEntity.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ class NrRlcAmTxEntity : public RlcAmTxEntityBase
4848
std::list<omnetpp::cPacket *> controlBuffer_;
4949
std::string nameEntity_;
5050
unsigned int sn_ = 0;
51-
unsigned int txNextAck_ = 0;
5251
unsigned int amWindowSize_ = 0;
5352
unsigned int pduWithoutPoll_ = 0;
5453
unsigned int byteWithoutPoll_ = 0;

src/simu5g/stack/rlc/am/packet/NrRlcAmDataPdu.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ NrRlcAmDataPdu::NrRlcAmDataPdu() : LteRlcDataPdu() {
1919
}
2020

2121
NrRlcAmDataPdu::~NrRlcAmDataPdu() {
22-
// TODO Auto-generated destructor stub
2322
}
2423

2524
} /* namespace simu5g */

src/simu5g/stack/rlc/um/NrRlcUmDataPdu.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ NrRlcUmDataPdu::NrRlcUmDataPdu() {
1818
}
1919

2020
NrRlcUmDataPdu::~NrRlcUmDataPdu() {
21-
// TODO Auto-generated destructor stub
2221
}
2322

2423
} /* namespace simu5g */

src/simu5g/stack/rlc/um/RlcUmReceptionBuffer.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ bool RlcUmReceptionBuffer::handleSegment(uint32_t sn, uint32_t totalLen, uint32_
8383
discardOutsideWindow();
8484

8585
if (!isWithinWindow(RX_Next_Reassembly)) {
86-
// TODO: we may be leaking sdu pointers here
8786
setNextReassemblyToFirstInWindow();
8887
}
8988
}

0 commit comments

Comments
 (0)