Pdcp: removed getDirection(), it trivially follows from node type

Redundant calls also removed, direction already set from setTrafficInformation()

Author: avarga

src/simu5g/stack/pdcp/LtePdcp.cc

@@ -61,7 +61,9 @@ void LtePdcpBase::setTrafficInformation(cPacket *pkt, inet::Ptr<FlowControlInfo>
         lteInfo->setRlcType(backgroundRlc_);
     }
 
-    lteInfo->setDirection(getDirection());
+    // direction of transmitted packets depends on node type
+    Direction dir = getNodeTypeById(nodeId_) == UE ? UL : DL;
+    lteInfo->setDirection(dir);
 }
 
 LogicalCid LtePdcpBase::lookupOrAssignLcid(const ConnectionKey& key)

src/simu5g/stack/pdcp/LtePdcp.h

@@ -256,7 +256,6 @@ class LtePdcpBase : public cSimpleModule
      *
      * @return Direction of traffic
      */
-    virtual Direction getDirection() = 0;
     void setTrafficInformation(cPacket *pkt, inet::Ptr<FlowControlInfo> lteInfo);
 
     /*
@@ -334,12 +333,6 @@ class LtePdcpUe : public LtePdcpBase
         return binder_->getNextHop(nodeId_);
     }
 
-    Direction getDirection() override
-    {
-        // Data coming from DataPort on UE are always Uplink
-        return UL;
-    }
-
   public:
     void initialize(int stage) override;
     void deleteEntities(MacNodeId nodeId) override;
@@ -373,12 +366,6 @@ class LtePdcpEnb : public LtePdcpBase
         return destId;
     }
 
-    Direction getDirection() override
-    {
-        // Data coming from DataPort on ENB are always Downlink
-        return DL;
-    }
-
   public:
     void initialize(int stage) override;
     void deleteEntities(MacNodeId nodeId) override;

src/simu5g/stack/pdcp/LtePdcpEnbD2D.cc

@@ -43,7 +43,6 @@ MacCid LtePdcpEnbD2D::analyzePacket(inet::Packet *pkt)
     // using D2D, set D2D direction. Otherwise, set UL direction
     srcId = binder_->getMacNodeId(srcAddr);
     destId = binder_->getMacNodeId(destAddr);   // get final destination
-    lteInfo->setDirection(getDirection());
 
     // check if src and dest of the flow are D2D-capable (currently in IM)
     if (getNodeTypeById(srcId) == UE && getNodeTypeById(destId) == UE && binder_->getD2DCapability(srcId, destId)) {

src/simu5g/stack/pdcp/LtePdcpUeD2D.h

@@ -39,7 +39,6 @@ class LtePdcpUeD2D : public LtePdcpUe
 
     MacNodeId getDestId(inet::Ptr<FlowControlInfo> lteInfo) override;
 
-    using LtePdcpUe::getDirection;  // base class variant: return direction for communication with eNB
     // additional getDirection method determining if D2D communication is available to a specific destination
     Direction getDirection(MacNodeId destId)
     {

src/simu5g/stack/pdcp/NrPdcpEnb.cc

@@ -48,7 +48,6 @@ MacCid NrPdcpEnb::analyzePacket(inet::Packet *pkt)
     // using D2D, set D2D direction. Otherwise, set UL direction
     srcId = (lteInfo->getUseNR()) ? binder_->getNrMacNodeId(srcAddr) : binder_->getMacNodeId(srcAddr);
     destId = (lteInfo->getUseNR()) ? binder_->getNrMacNodeId(destAddr) : binder_->getMacNodeId(destAddr);   // get final destination
-    lteInfo->setDirection(getDirection());
 
     // check if src and dest of the flow are D2D-capable UEs (currently in IM)
     if (getNodeTypeById(srcId) == UE && getNodeTypeById(destId) == UE && binder_->getD2DCapability(srcId, destId)) {