Skip to content

Commit c0e402f

Browse files
committed
Pdcp: TODO items
1 parent 1b238ad commit c0e402f

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

src/simu5g/stack/pdcp/LtePdcp.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ class LtePdcpBase : public cSimpleModule
283283
*
284284
* Returns the (nodeId,LCID) pair that identifies the connection for the packet.
285285
*/
286-
virtual MacCid analyzePacket(inet::Packet *pkt);
286+
virtual MacCid analyzePacket(inet::Packet *pkt); //TODO this stuff in here has 99% nothing to do with the PDCP protocol, should be moved out into a different module
287287

288288
/**
289289
* Process data packets from higher layers.

src/simu5g/stack/pdcp/NrPdcpEnb.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ void NrPdcpEnb::forwardDataToTargetNode(Packet *pkt, MacNodeId targetNode)
130130
dualConnectivityManager_->forwardDataToTargetNode(pkt, targetNode);
131131
}
132132

133+
//TODO this is called from DualConnectivityManager, likely has nothing to do with the PDCP protocol
133134
void NrPdcpEnb::receiveDataFromSourceNode(Packet *pkt, MacNodeId sourceNode)
134135
{
135136
Enter_Method("receiveDataFromSourceNode");

0 commit comments

Comments
 (0)