Skip to content

Commit ce19e38

Browse files
barryobarryo
committed
psalm baseline updated
1 parent 86dac34 commit ce19e38

File tree

1 file changed

+164
-16
lines changed

1 file changed

+164
-16
lines changed

Diff for: ‎psalm-baseline.xml

+164-16
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,9 @@
120120
</UndefinedMagicMethod>
121121
</file>
122122
<file src="app/Console/Commands/InManrs.php">
123+
<UndefinedConstant>
124+
<code><![CDATA[APPLICATION_VERSION]]></code>
125+
</UndefinedConstant>
123126
<UndefinedMagicMethod>
124127
<code><![CDATA[current]]></code>
125128
<code><![CDATA[current]]></code>
@@ -164,6 +167,45 @@
164167
<code><![CDATA[public function handle(): int]]></code>
165168
</MissingDocblockType>
166169
</file>
170+
<file src="app/Console/Commands/Redcentric.php">
171+
<UndefinedMagicMethod>
172+
<code><![CDATA[CustomerToUser::updateOrCreate(
173+
[
174+
'customer_id' => $u->custid,
175+
'user_id' => $u->id,
176+
],
177+
[
178+
'privs' => $u->privs,
179+
]
180+
)]]></code>
181+
<code><![CDATA[User2FA::updateOrCreate(
182+
[ 'user_id' => $uid ],
183+
[
184+
'enabled' => isset( $up['tfa.totp.enabled'] ) && ( $up['tfa.totp.enabled'][0] == 1 ),
185+
'secret' => isset( $up['tfa.totp.secret'] ) ? $up['tfa.totp.secret'][0] : null,
186+
]
187+
)]]></code>
188+
<code><![CDATA[User::find( $uid )]]></code>
189+
<code><![CDATA[User::updateOrCreate(
190+
[ 'id' => $uc[0] ],
191+
[
192+
'custid' => $uc[1],
193+
'username' => $uc[2],
194+
'password' => $uc[3],
195+
'email' => $uc[4],
196+
'authorisedMobile' => $uc[5],
197+
'uid' => $uc[6],
198+
'privs' => $uc[7],
199+
'disabled' => $uc[8],
200+
'lastupdatedby' => $uc[10],
201+
'creator' => $uc[11],
202+
'created_at' => $uc[12],
203+
'updated_at' => $uc[9],
204+
],
205+
)]]></code>
206+
<code><![CDATA[User::where('username', $uc[2] )]]></code>
207+
</UndefinedMagicMethod>
208+
</file>
167209
<file src="app/Console/Commands/RipeAtlas/CompleteRequests.php">
168210
<MissingDocblockType>
169211
<code><![CDATA[public function handle(): int]]></code>
@@ -380,6 +422,10 @@
380422
<MissingDocblockType>
381423
<code><![CDATA[public function create( Request $r, Customer $cust ): JsonResponse]]></code>
382424
</MissingDocblockType>
425+
<NoInterfaceProperties>
426+
<code><![CDATA[Auth::getUser()->custid]]></code>
427+
<code><![CDATA[Auth::getUser()->customer]]></code>
428+
</NoInterfaceProperties>
383429
</file>
384430
<file src="app/Http/Controllers/Api/V4/CustomerController.php">
385431
<UndefinedMagicMethod>
@@ -455,6 +501,14 @@
455501
<MissingDocblockType>
456502
<code><![CDATA[public function test( Request $r ): Response|JsonResponse]]></code>
457503
</MissingDocblockType>
504+
<NoInterfaceProperties>
505+
<code><![CDATA[Auth::getUser()->customer]]></code>
506+
<code><![CDATA[Auth::getUser()->customer]]></code>
507+
<code><![CDATA[Auth::getUser()->id]]></code>
508+
<code><![CDATA[Auth::getUser()->privs]]></code>
509+
<code><![CDATA[Auth::getUser()->username]]></code>
510+
<code><![CDATA[Auth::getUser()->username]]></code>
511+
</NoInterfaceProperties>
458512
<UndefinedMagicMethod>
459513
<code><![CDATA[Infrastructure::select( [ 'i.name', 'i.shortname', 'i.ixf_ix_id', 'i.peeringdb_ix_id' ] )]]></code>
460514
</UndefinedMagicMethod>
@@ -598,6 +652,14 @@
598652
<code><![CDATA[config( 'ixp_fe.lang.customer.one' )]]></code>
599653
<code><![CDATA[config( 'ixp_fe.lang.customer.one' )]]></code>
600654
</InvalidOperand>
655+
<NoInterfaceProperties>
656+
<code><![CDATA[Auth::getUser()->name]]></code>
657+
<code><![CDATA[Auth::getUser()->name]]></code>
658+
<code><![CDATA[Auth::getUser()->name]]></code>
659+
<code><![CDATA[Auth::getUser()->name]]></code>
660+
<code><![CDATA[Auth::getUser()->username]]></code>
661+
<code><![CDATA[Auth::getUser()->username]]></code>
662+
</NoInterfaceProperties>
601663
<UndefinedMagicMethod>
602664
<code><![CDATA[Customer::find( session()->get( "switched_customer_from" ) )]]></code>
603665
<code><![CDATA[CustomerToUser::find( session()->get( "switched_c2u_to" ) )]]></code>
@@ -664,6 +726,9 @@
664726
<code><![CDATA[public function doStore( Request $r ): bool|RedirectResponse]]></code>
665727
<code><![CDATA[public function doUpdate( Request $r, int $id ): bool|RedirectResponse]]></code>
666728
</MissingDocblockType>
729+
<NoInterfaceProperties>
730+
<code><![CDATA[Auth::getUser()->custid]]></code>
731+
</NoInterfaceProperties>
667732
<RedundantCondition>
668733
<code><![CDATA[User::AUTH_CUSTADMIN]]></code>
669734
<code><![CDATA[User::AUTH_CUSTUSER]]></code>
@@ -822,6 +887,9 @@
822887
<code><![CDATA[public function logos(): View]]></code>
823888
<code><![CDATA[public function store( LogoRequest $r ): RedirectResponse]]></code>
824889
</MissingDocblockType>
890+
<NoInterfaceProperties>
891+
<code><![CDATA[Auth::getUser()->custid]]></code>
892+
</NoInterfaceProperties>
825893
<UndefinedMagicMethod>
826894
<code><![CDATA[Customer::find( Auth::getUser()->custid )]]></code>
827895
<code><![CDATA[Customer::findOrFail( $id )]]></code>
@@ -840,8 +908,18 @@
840908
<code><![CDATA[public function storeBillingDetails( BillingDetailsRequest $r ): RedirectResponse]]></code>
841909
<code><![CDATA[public function storeNocDetails( NocDetailsRequest $r ): RedirectResponse]]></code>
842910
</MissingDocblockType>
911+
<NoInterfaceProperties>
912+
<code><![CDATA[Auth::getUser()->customer]]></code>
913+
<code><![CDATA[Auth::getUser()->customer]]></code>
914+
<code><![CDATA[Auth::getUser()->customer]]></code>
915+
</NoInterfaceProperties>
843916
</file>
844917
<file src="app/Http/Controllers/Docstore/DirectoryController.php">
918+
<NoInterfaceProperties>
919+
<code><![CDATA[$user->privs]]></code>
920+
<code><![CDATA[Auth::getUser()->username]]></code>
921+
<code><![CDATA[Auth::user()->username]]></code>
922+
</NoInterfaceProperties>
845923
<UndefinedMagicMethod>
846924
<code><![CDATA[DocstoreDirectory::create( $r->all() )]]></code>
847925
</UndefinedMagicMethod>
@@ -850,6 +928,11 @@
850928
<InvalidOperand>
851929
<code><![CDATA[config( 'filesystems.disks.' . $file->disk . '.root', '*** UNKNOWN LOCATION ***' )]]></code>
852930
</InvalidOperand>
931+
<NoInterfaceProperties>
932+
<code><![CDATA[$user->username]]></code>
933+
<code><![CDATA[$user->username]]></code>
934+
<code><![CDATA[Auth::user()->username]]></code>
935+
</NoInterfaceProperties>
853936
<UndefinedMagicMethod>
854937
<code><![CDATA[DocstoreFile::create( [
855938
'name' => $r->name,
@@ -1254,13 +1337,22 @@
12541337
</UndefinedMagicMethod>
12551338
</file>
12561339
<file src="app/Http/Controllers/PatchPanel/Port/DangerActionsController.php">
1340+
<NoInterfaceProperties>
1341+
<code><![CDATA[Auth::getUser()->username]]></code>
1342+
<code><![CDATA[Auth::getUser()->username]]></code>
1343+
<code><![CDATA[Auth::getUser()->username]]></code>
1344+
<code><![CDATA[Auth::getUser()->username]]></code>
1345+
</NoInterfaceProperties>
12571346
<UndefinedMagicMethod>
12581347
<code><![CDATA[PatchPanel::select( [ 'pp.id', 'pp.name' ] )]]></code>
12591348
<code><![CDATA[PatchPanelPort::find( $r->port_id )]]></code>
12601349
<code><![CDATA[PatchPanelPort::find( $r->slave_id )]]></code>
12611350
</UndefinedMagicMethod>
12621351
</file>
12631352
<file src="app/Http/Controllers/PatchPanel/Port/FileController.php">
1353+
<NoInterfaceProperties>
1354+
<code><![CDATA[Auth::getUser()->username]]></code>
1355+
</NoInterfaceProperties>
12641356
<UndefinedMagicMethod>
12651357
<code><![CDATA[PatchPanelPortFile::create( [
12661358
'patch_panel_port_id' => $ppp->id,
@@ -1322,6 +1414,14 @@
13221414
<code><![CDATA[public function peeringNotes( Request $r ): JsonResponse]]></code>
13231415
<code><![CDATA[public function sendPeeringEmail( PeeringManagerRequest $r ) : JsonResponse]]></code>
13241416
</MissingDocblockType>
1417+
<NoInterfaceProperties>
1418+
<code><![CDATA[Auth::getUser()->custid]]></code>
1419+
<code><![CDATA[Auth::getUser()->custid]]></code>
1420+
<code><![CDATA[Auth::getUser()->custid]]></code>
1421+
<code><![CDATA[Auth::getUser()->custid]]></code>
1422+
<code><![CDATA[Auth::getUser()->custid]]></code>
1423+
<code><![CDATA[Auth::getUser()->custid]]></code>
1424+
</NoInterfaceProperties>
13251425
<UndefinedMagicMethod>
13261426
<code><![CDATA[Customer::find( $r->peerid )]]></code>
13271427
<code><![CDATA[Customer::find( Auth::getUser()->custid )]]></code>
@@ -1379,6 +1479,12 @@
13791479
<code><![CDATA[public function updatePassword( PasswordRequest $r ): RedirectResponse]]></code>
13801480
<code><![CDATA[public function updateProfile( ProfileRequest $r ): RedirectResponse]]></code>
13811481
</MissingDocblockType>
1482+
<NoInterfaceProperties>
1483+
<code><![CDATA[Auth::getUser()->prefs]]></code>
1484+
</NoInterfaceProperties>
1485+
<TypeDoesNotContainType>
1486+
<code><![CDATA[Auth::getUser()->prefs[ 'notes' ][ 'global_notifs' ]]]></code>
1487+
</TypeDoesNotContainType>
13821488
<UndefinedMagicMethod>
13831489
<code><![CDATA[UserRememberToken::where( 'user_id', $user->id )]]></code>
13841490
</UndefinedMagicMethod>
@@ -1466,6 +1572,13 @@
14661572
<InvalidOperand>
14671573
<code><![CDATA[config('ixp_fe.rs-filters.ttl' )]]></code>
14681574
</InvalidOperand>
1575+
<NoInterfaceProperties>
1576+
<code><![CDATA[Auth::getUser()->username]]></code>
1577+
<code><![CDATA[Auth::getUser()->username]]></code>
1578+
<code><![CDATA[Auth::getUser()->username]]></code>
1579+
<code><![CDATA[Auth::getUser()->username]]></code>
1580+
<code><![CDATA[Auth::getUser()->username]]></code>
1581+
</NoInterfaceProperties>
14691582
<RedundantCondition>
14701583
<code><![CDATA[(string)$rsf->peer_id]]></code>
14711584
<code><![CDATA[(string)$rsf->vlan_id]]></code>
@@ -1539,6 +1652,10 @@
15391652
<code><![CDATA[public function routesForTable( string $handle, string $table )]]></code>
15401653
<code><![CDATA[public function status( string $handle ): Response]]></code>
15411654
</MissingDocblockType>
1655+
<NoInterfaceProperties>
1656+
<code><![CDATA[Auth::getUser()->custid]]></code>
1657+
<code><![CDATA[Auth::getUser()->custid]]></code>
1658+
</NoInterfaceProperties>
15421659
<UndefinedMagicMethod>
15431660
<code><![CDATA[Customer::find( Auth::getUser()->custid )]]></code>
15441661
<code><![CDATA[Customer::find( Auth::getUser()->custid )]]></code>
@@ -1703,6 +1820,11 @@
17031820
</UndefinedMagicMethod>
17041821
</file>
17051822
<file src="app/Http/Controllers/User/CustomerToUserController.php">
1823+
<NoInterfaceProperties>
1824+
<code><![CDATA[Auth::getUser()->username]]></code>
1825+
<code><![CDATA[Auth::getUser()->username]]></code>
1826+
<code><![CDATA[Auth::user()->customer]]></code>
1827+
</NoInterfaceProperties>
17061828
<RedundantCondition>
17071829
<code><![CDATA[$disassociatedUser->customers()]]></code>
17081830
</RedundantCondition>
@@ -1739,6 +1861,13 @@
17391861
abort(404, 'UserToCustomer not found');
17401862
}]]></code>
17411863
</MissingDocblockType>
1864+
<NoInterfaceProperties>
1865+
<code><![CDATA[Auth::user()->custid]]></code>
1866+
<code><![CDATA[Auth::user()->custid]]></code>
1867+
<code><![CDATA[Auth::user()->custid]]></code>
1868+
<code><![CDATA[Auth::user()->username]]></code>
1869+
<code><![CDATA[Auth::user()->username]]></code>
1870+
</NoInterfaceProperties>
17421871
<RedundantFunctionCall>
17431872
<code><![CDATA[sprintf]]></code>
17441873
</RedundantFunctionCall>
@@ -1839,6 +1968,12 @@
18391968
<code><![CDATA[CustomerToUser::where( [ 'user_id' => Auth::id() ] )]]></code>
18401969
</UndefinedMagicMethod>
18411970
</file>
1971+
<file src="app/Http/Middleware/Google2FA.php">
1972+
<NoInterfaceProperties>
1973+
<code><![CDATA[Auth::getUser()->user2FA]]></code>
1974+
<code><![CDATA[Auth::getUser()->user2FA]]></code>
1975+
</NoInterfaceProperties>
1976+
</file>
18421977
<file src="app/Http/Middleware/RsPrefixes.php">
18431978
<InvalidCast>
18441979
<code><![CDATA[config( 'ixp_fe.rs-prefixes.access' )]]></code>
@@ -1892,6 +2027,16 @@
18922027
<code><![CDATA[PatchPanelPort::find( $this->port_id )]]></code>
18932028
</UndefinedMagicMethod>
18942029
</file>
2030+
<file src="app/Http/Requests/Profile/Password.php">
2031+
<NoInterfaceProperties>
2032+
<code><![CDATA[Auth::getUser()->password]]></code>
2033+
</NoInterfaceProperties>
2034+
</file>
2035+
<file src="app/Http/Requests/Profile/Profile.php">
2036+
<NoInterfaceProperties>
2037+
<code><![CDATA[Auth::getUser()->password]]></code>
2038+
</NoInterfaceProperties>
2039+
</file>
18952040
<file src="app/Http/Requests/RouteServerFilter/Store.php">
18962041
<UndefinedMagicMethod>
18972042
<code><![CDATA[Customer::find( $value )]]></code>
@@ -1910,6 +2055,9 @@
19102055
</UndefinedMagicMethod>
19112056
</file>
19122057
<file src="app/Http/Requests/User/Delete.php">
2058+
<NoInterfaceProperties>
2059+
<code><![CDATA[Auth::user()->username]]></code>
2060+
</NoInterfaceProperties>
19132061
<UndefinedMagicMethod>
19142062
<code><![CDATA[CustomerToUser::where( 'customer_id', $us->custid )]]></code>
19152063
</UndefinedMagicMethod>
@@ -2881,6 +3029,11 @@
28813029
<code><![CDATA[public function move( PatchPanelPort $dest, PatchPanelPort $slave = null ): bool]]></code>
28823030
<code><![CDATA[public function remove(): void]]></code>
28833031
</MissingDocblockType>
3032+
<NoInterfaceProperties>
3033+
<code><![CDATA[Auth::getUser()->username]]></code>
3034+
<code><![CDATA[Auth::getUser()->username]]></code>
3035+
<code><![CDATA[Auth::getUser()->username]]></code>
3036+
</NoInterfaceProperties>
28843037
<TypeDoesNotContainType>
28853038
<code><![CDATA[!( $history = $this->archive() )]]></code>
28863039
</TypeDoesNotContainType>
@@ -3175,6 +3328,13 @@
31753328
<code><![CDATA[CustomerToUser::where( 'customer_id', $auth->custid )]]></code>
31763329
</UndefinedMagicMethod>
31773330
</file>
3331+
<file src="app/Providers/AuthServiceProvider.php">
3332+
<RedundantCondition>
3333+
<code><![CDATA[method_exists( $guard, 'setCookieJar' )]]></code>
3334+
<code><![CDATA[method_exists( $guard, 'setDispatcher' )]]></code>
3335+
<code><![CDATA[method_exists( $guard, 'setRequest' )]]></code>
3336+
</RedundantCondition>
3337+
</file>
31783338
<file src="app/Providers/DiagnosticsServiceProvider.php">
31793339
<MissingDocblockType>
31803340
<code><![CDATA[public function boot(): void]]></code>
@@ -3595,11 +3755,6 @@
35953755
<code><![CDATA[public function forRouter( Router $router )]]></code>
35963756
</MissingDocblockType>
35973757
</file>
3598-
<file src="app/Services/LookingGlass/BirdsEye.php">
3599-
<InvalidDocblock>
3600-
<code><![CDATA[public function setCacheEnabled( bool $b ): BirdsEye]]></code>
3601-
</InvalidDocblock>
3602-
</file>
36033758
<file src="app/Services/PeeringDb.php">
36043759
<InvalidOperand>
36053760
<code><![CDATA[config( 'ixp_api.peeringDB.api-key' )]]></code>
@@ -3758,17 +3913,11 @@
37583913
</ImplementedReturnTypeMismatch>
37593914
</file>
37603915
<file src="app/Utils/Grapher/Mrtg.php">
3761-
<InvalidDocblock>
3762-
<code><![CDATA[public function getPeriodTime( $period ): float]]></code>
3763-
</InvalidDocblock>
37643916
<MissingDocblockType>
37653917
<code><![CDATA[protected function loadMrtgFile(): array]]></code>
37663918
</MissingDocblockType>
37673919
</file>
37683920
<file src="app/Utils/Grapher/Rrd.php">
3769-
<InvalidDocblock>
3770-
<code><![CDATA[public function getPeriodTime( $period ): float]]></code>
3771-
</InvalidDocblock>
37723921
<InvalidScalarArgument>
37733922
<code><![CDATA[$this->graph()->periodEnd()->timestamp]]></code>
37743923
<code><![CDATA[$this->graph()->periodStart()->timestamp]]></code>
@@ -3791,17 +3940,16 @@
37913940
<code><![CDATA[$rrd === false || !is_array( $rrd )]]></code>
37923941
</TypeDoesNotContainType>
37933942
</file>
3794-
<file src="app/Utils/Horizon.php">
3795-
<InvalidDocblock>
3796-
<code><![CDATA[public static function status()]]></code>
3797-
</InvalidDocblock>
3798-
</file>
37993943
<file src="app/Utils/Http/Controllers/Frontend/EloquentController.php">
38003944
<MissingDocblockType>
38013945
<code><![CDATA[public function delete( Request $r ): RedirectResponse]]></code>
38023946
<code><![CDATA[public function edit( int $id ): View]]></code>
38033947
<code><![CDATA[public function store( Request $r )]]></code>
38043948
</MissingDocblockType>
3949+
<NoInterfaceProperties>
3950+
<code><![CDATA[Auth::getUser()->username]]></code>
3951+
<code><![CDATA[Auth::getUser()->username]]></code>
3952+
</NoInterfaceProperties>
38053953
<RedundantCondition>
38063954
<code><![CDATA[is_array( $data )]]></code>
38073955
</RedundantCondition>

0 commit comments

Comments
 (0)