Skip to content

friends' messages are not being highlighted #23

@bretonium

Description

@bretonium

Steps to reproduce:

  1. Add someone to friends
    • this can be done, for example, via the "friends" tab in the lower-right part of the screen by typing their name
    • or by clicking on the player in the "info" tab in the player list
    • or via the add_friend command in the console
  2. Get the friend to write something in the chat

Expected: the friend's messages is highlighted
Observed: the friend's message is not highlighted unless they are in the spectators

Screenshot_20220225_120706

The issue is not exclusive to infclass-client, ddnet and teeworlds clients also suffer from this. But infclass-client looks like an easy place to start fixing it. I think the issue happens because the class of players is communicated via the "Clan" field, and it seems to be participating in the friend-matching.

The issue affects not only highlighting of the messages; it also affects the "Only show chat messages from friends" option in the client, rendering it useless.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions