Skip to content
This repository was archived by the owner on Oct 16, 2024. It is now read-only.

Commit cedcf72

Browse files
authored
#434 Fix readability nits
2 parents 43c5581 + 78e4c5b commit cedcf72

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

src/main/java/org/inferred/freebuilder/processor/excerpt/CheckedBiMap.java

+4-6
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,8 @@ public void addTo(SourceBuilder code) {
5050
.addLine(" @Override public V put(K key, V value) {")
5151
.addLine(" K oldKey = biMap.inverse().get(value);")
5252
.addLine(" %s.checkArgument(", Preconditions.class)
53-
.addLine(" oldKey == null || %s.equals(oldKey, key),"
54-
+ " \"value already present: %%s\", value);",
55-
Objects.class)
53+
.addLine(" oldKey == null || %s.equals(oldKey, key),", Objects.class)
54+
.addLine(" \"value already present: %%s\", value);")
5655
.addLine(" V oldValue = biMap.get(key);")
5756
.addLine(" forcePut.accept(key, value);")
5857
.addLine(" return oldValue;")
@@ -131,9 +130,8 @@ public void addTo(SourceBuilder code) {
131130
.addLine(" @Override public V setValue(V value) {")
132131
.addLine(" K oldKey = biMap.inverse().get(value);")
133132
.addLine(" %s.checkArgument(", Preconditions.class)
134-
.addLine(" oldKey == null || %s.equals(oldKey, key),"
135-
+ " \"value already present: %%s\", value);",
136-
Objects.class)
133+
.addLine(" oldKey == null || %s.equals(oldKey, key),", Objects.class)
134+
.addLine(" \"value already present: %%s\", value);")
137135
.addLine(" V oldValue = this.value;")
138136
.addLine(" this.value = %s.requireNonNull(value);", Objects.class)
139137
.addLine(" forcePut.accept(key, value);")

src/main/java/org/inferred/freebuilder/processor/property/BiMapProperty.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,8 @@ private void addPut(SourceBuilder code) {
228228
unboxedValueType.orElse(valueType));
229229
code.addLine(" %s oldKey = %s.inverse().get(value);", keyType, property.getField())
230230
.addLine(" %s.checkArgument(", Preconditions.class)
231-
.addLine(" oldKey == null || %s.equals(oldKey, key),"
232-
+ " \"value already present: %%s\", value);",
233-
Objects.class)
231+
.addLine(" oldKey == null || %s.equals(oldKey, key),", Objects.class)
232+
.addLine(" \"value already present: %%s\", value);")
234233
.addLine(" %s(key, value);", forcePutMethod(property))
235234
.addLine(" return (%s) this;", datatype.getBuilder())
236235
.addLine("}");

0 commit comments

Comments
 (0)