Skip to content
This repository was archived by the owner on Oct 16, 2024. It is now read-only.

Commit efb5572

Browse files
authored
#426 Remove redundant null checks from bimap put
2 parents 3000ccf + af5d93c commit efb5572

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

src/main/java/org/inferred/freebuilder/processor/property/BiMapProperty.java

-6
Original file line numberDiff line numberDiff line change
@@ -200,12 +200,6 @@ private void addPut(SourceBuilder code) {
200200
putMethod(property),
201201
unboxedKeyType.orElse(keyType),
202202
unboxedValueType.orElse(valueType));
203-
if (!unboxedKeyType.isPresent()) {
204-
code.addLine(" %s.requireNonNull(key);", Objects.class);
205-
}
206-
if (!unboxedValueType.isPresent()) {
207-
code.addLine(" %s.requireNonNull(value);", Objects.class);
208-
}
209203
code.addLine(" %s.checkArgument(", Preconditions.class)
210204
.addLine(" !%s.containsValue(value), \"value already present: %%s\", value);",
211205
property.getField())

src/test/java/org/inferred/freebuilder/processor/property/BiMapSourceTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ public void test_guava() {
9090
" * @throws NullPointerException if {@code value} is null",
9191
" */",
9292
" public Person.Builder putName(int key, String value) {",
93-
" Objects.requireNonNull(value);",
9493
" Preconditions.checkArgument(!name.containsValue(value), \"value already present: %s\", value);",
9594
" forcePutName(key, value);",
9695
" return (Person.Builder) this;",

0 commit comments

Comments
 (0)