Skip to content

Commit de53a6a

Browse files
Katia Arestikaresti
authored andcommitted
[#643] Refresh schema list on delete
1 parent 8610a5a commit de53a6a

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

src/app/Caches/Create/Features/BackupsCacheConfigurator.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ const BackupsCacheConfigurator = (props: { isEnabled: boolean }) => {
169169
name={index.toString()}
170170
id={`async-${index}`}
171171
onChange={() => {
172-
(site.siteStrategy = BackupSiteStrategy.ASYNC),
173-
setSites(sites.map((chip) => (chip.siteName === site.siteName ? site : chip)));
172+
((site.siteStrategy = BackupSiteStrategy.ASYNC),
173+
setSites(sites.map((chip) => (chip.siteName === site.siteName ? site : chip))));
174174
}}
175175
isChecked={site.siteStrategy === 'ASYNC'}
176176
label={t('caches.create.configurations.feature.strategy-async')}
@@ -179,8 +179,8 @@ const BackupsCacheConfigurator = (props: { isEnabled: boolean }) => {
179179
name={index.toString()}
180180
id={`sync-${index}`}
181181
onChange={() => {
182-
(site.siteStrategy = BackupSiteStrategy.SYNC),
183-
setSites(sites.map((chip) => (chip.siteName === site.siteName ? site : chip)));
182+
((site.siteStrategy = BackupSiteStrategy.SYNC),
183+
setSites(sites.map((chip) => (chip.siteName === site.siteName ? site : chip))));
184184
}}
185185
isChecked={site.siteStrategy === 'SYNC'}
186186
label={t('caches.create.configurations.feature.strategy-sync')}

src/app/ProtoSchema/ProtobufSchemasDisplay.tsx

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,12 @@ const ProtobufSchemasDisplay = (props: { setProtoSchemasCount: (number) => void;
9696
status: t('schemas.status')
9797
};
9898

99+
useEffect(() => {
100+
if (props.isVisible) {
101+
reload();
102+
}
103+
}, [props.isVisible]);
104+
99105
useEffect(() => {
100106
if (schemas) {
101107
props.setProtoSchemasCount(schemas.length);
@@ -145,11 +151,6 @@ const ProtobufSchemasDisplay = (props: { setProtoSchemasCount: (number) => void;
145151
setEditSchemaName('');
146152
};
147153

148-
const closeDeleteSchemaModal = () => {
149-
setDeleteSchemaName('');
150-
reload();
151-
};
152-
153154
const submitEditSchemaModal = () => {
154155
setEditSchemaName('');
155156
reload();
@@ -286,7 +287,7 @@ const ProtobufSchemasDisplay = (props: { setProtoSchemasCount: (number) => void;
286287
>
287288
<Thead>
288289
<Tr>
289-
<Th />
290+
<Th screenReaderText={'expand button'}></Th>
290291
<Th width={30}>{columnNames.name}</Th>
291292
<Th width={60}>{columnNames.status}</Th>
292293
</Tr>
@@ -368,7 +369,10 @@ const ProtobufSchemasDisplay = (props: { setProtoSchemasCount: (number) => void;
368369
<DeleteSchema
369370
schemaName={deleteSchemaName}
370371
isModalOpen={deleteSchemaName !== ''}
371-
closeModal={closeDeleteSchemaModal}
372+
closeModal={() => {
373+
setDeleteSchemaName('');
374+
reload();
375+
}}
372376
/>
373377
</React.Fragment>
374378
);

0 commit comments

Comments
 (0)