fix(cli): warn macOS users about spaces in path (#2550 by @frankcalise)

* fix(boilerplate): Podfile accounts for spaces in path

* fix(cli): check for spaces in path on macOS

* chore: cleanup

Author: frankcalise

boilerplate/ios/Podfile

@@ -1,8 +1,6 @@
-pod_folder = Pathname.new(__FILE__).dirname.realpath
-
-require File.join(File.dirname(`cd #{pod_folder} && node --print "require.resolve('expo/package.json')"`), "scripts/autolinking")
-require File.join(File.dirname(`cd #{pod_folder} && node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods")
-require File.join(File.dirname(`cd #{pod_folder} && node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules")
+require File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking")
+require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods")
+require File.join(File.dirname(`node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules")
 
 require 'json'
 podfile_properties = JSON.parse(File.read(File.join(__dir__, 'Podfile.properties.json'))) rescue {}

src/commands/new.ts

@@ -137,6 +137,7 @@ export default {
     const { gray, cyan, yellow, white, red, underline } = colors
     const options: Options = parameters.options
 
+    const isMac = process.platform === "darwin"
     const yname = boolFlag(options.y) || boolFlag(options.yes)
     const useDefault = (option: unknown) => yname && option === undefined
 
@@ -218,6 +219,11 @@ export default {
       p?.startsWith("~") ? p.replace("~", homedir()) : p
     targetPath = path(handleHomePrefix(targetPath))
 
+    if (isMac && targetPath.indexOf(" ") !== -1) {
+      p()
+      p(yellow("Error: The project path cannot contain spaces."))
+      process.exit(1)
+    }
     // #endregion
 
     // #region Prompt Overwrite
@@ -711,7 +717,6 @@ export default {
       if (!installDeps) command(packager.installCmd({ packagerName }))
       command(`${packagerName} start`)
 
-      const isMac = process.platform === "darwin"
       if (isMac) {
         command(`${packager.runCmd("ios", packagerOptions)}`)
       } else {