Skip to content

Commit c52cd97

Browse files
committed
Merge branch 'master' of github.com:infinitered/react_native_base
2 parents 407b420 + 2c1cdec commit c52cd97

File tree

5 files changed

+32
-31
lines changed

5 files changed

+32
-31
lines changed

ignite-base/App/Root.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import Actions from './Actions/Creators'
66
import Drawer from 'react-native-drawer'
77
import DebugSettings from './Config/DebugSettings'
88
import DrawerContent from './Components/DrawerContent'
9-
import './Config/PushConfig'
9+
// import './Config/PushConfig'
1010

1111
// Styles
1212
import styles, {drawerStyles} from './Containers/Styles/RootStyle'

ignite-base/ios/RNBase/AppDelegate.m

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#import "AppDelegate.h"
1111

1212
#import "RCTRootView.h"
13-
#import "RCTPushNotificationManager.h"
13+
// #import "RCTPushNotificationManager.h"
1414

1515
@implementation AppDelegate
1616

@@ -59,29 +59,29 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
5959
return YES;
6060
}
6161

62-
// Required to register for notifications
63-
- (void)application:(UIApplication *)application didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings
64-
{
65-
[RCTPushNotificationManager didRegisterUserNotificationSettings:notificationSettings];
66-
}
67-
68-
// Required for the register event.
69-
- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
70-
{
71-
[RCTPushNotificationManager didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];
72-
}
73-
74-
// Required for the notification event.
75-
- (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)notification
76-
{
77-
[RCTPushNotificationManager didReceiveRemoteNotification:notification];
78-
}
79-
80-
// Required for the localNotification event.
81-
- (void)application:(UIApplication *)application didReceiveLocalNotification:(UILocalNotification *)notification
82-
{
83-
[RCTPushNotificationManager didReceiveLocalNotification:notification];
84-
}
62+
// // Required to register for notifications
63+
// - (void)application:(UIApplication *)application didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings
64+
// {
65+
// [RCTPushNotificationManager didRegisterUserNotificationSettings:notificationSettings];
66+
// }
67+
68+
// // Required for the register event.
69+
// - (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
70+
// {
71+
// [RCTPushNotificationManager didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];
72+
// }
73+
74+
// // Required for the notification event.
75+
// - (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)notification
76+
// {
77+
// [RCTPushNotificationManager didReceiveRemoteNotification:notification];
78+
// }
79+
80+
// // Required for the localNotification event.
81+
// - (void)application:(UIApplication *)application didReceiveLocalNotification:(UILocalNotification *)notification
82+
// {
83+
// [RCTPushNotificationManager didReceiveLocalNotification:notification];
84+
// }
8585

8686

8787
@end

ignite-base/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,11 @@
2424
"querystringify": "0.0.3",
2525
"ramda": "^0.21.0",
2626
"react": "^15.1.0",
27-
"react-native": "^0.27.2",
27+
"react-native": "^0.28.0",
2828
"react-native-animatable": "^0.6.0",
2929
"react-native-device-info": "^0.9.3",
3030
"react-native-drawer": "^2.2.4",
3131
"react-native-i18n": "0.0.8",
32-
"react-native-push-notification": "^1.0.7",
3332
"react-native-vector-icons": "^2.0.2",
3433
"react-redux": "^4.4.2",
3534
"redux": "^3.4.0",

ignite-base/package.json.template

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,11 @@
2424
"querystringify": "0.0.3",
2525
"ramda": "^0.21.0",
2626
"react": "^15.1.0",
27-
"react-native": "^0.27.2",
27+
"react-native": "^0.28.0",
2828
"react-native-animatable": "^0.6.0",
2929
"react-native-device-info": "^0.9.3",
3030
"react-native-drawer": "^2.2.4",
3131
"react-native-i18n": "0.0.8",
32-
"react-native-push-notification": "^1.0.7",
3332
"react-native-vector-icons": "^2.0.2",
3433
"react-redux": "^4.4.2",
3534
"redux": "^3.4.0",

ignite-generator/src/app/index.es

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -374,8 +374,11 @@ export class AppGenerator extends Generators.Base {
374374
this.spinner.stop()
375375
this.log(`${check} ${rnpmStatus}`)
376376

377-
// then update the android manifest
378-
this._updateAndroidManifest()
377+
// Push notifications code, disabled for now
378+
// Causing issues :(
379+
// update the android manifest
380+
// this._updateAndroidManifest()
381+
379382
// then update Plist
380383
this._updatePList()
381384
done()

0 commit comments

Comments
 (0)