Skip to content

Commit ef83a36

Browse files
authored
fix(boilerplate): remove unnecessary withSplashScreen plugin (#3004 by @frankcalise)
* fix(boilerplate): remove unnecessary withSplashScreen plugin * chore: lint * chore(boilerplate): add doc link around dynamic app config plugins
1 parent 0a1746c commit ef83a36

File tree

5 files changed

+7
-91
lines changed

5 files changed

+7
-91
lines changed

boilerplate/app.config.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
import { ExpoConfig, ConfigContext } from "@expo/config"
22

33
/**
4-
* Use ts-node here so we can use TypeScript for our Config Plugins
5-
* and not have to compile them to JavaScript
4+
* Use tsx/cjs here so we can use TypeScript for our Config Plugins
5+
* and not have to compile them to JavaScript.
6+
*
7+
* See https://docs.expo.dev/config-plugins/plugins/#add-typescript-support-and-convert-to-dynamic-app-config
68
*/
7-
require("ts-node/register")
9+
import "tsx/cjs"
810

911
/**
1012
* @param config ExpoConfig coming from the static config app.json if it exists
@@ -34,6 +36,6 @@ module.exports = ({ config }: ConfigContext): Partial<ExpoConfig> => {
3436
],
3537
},
3638
},
37-
plugins: [...existingPlugins, require("./plugins/withSplashScreen").withSplashScreen],
39+
plugins: [...existingPlugins],
3840
}
3941
}

boilerplate/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
"reactotron-react-native": "^5.0.5",
9090
"reactotron-react-native-mmkv": "^0.2.6",
9191
"ts-jest": "^29.1.1",
92-
"ts-node": "^10.9.2",
92+
"tsx": "^4.20.3",
9393
"typescript": "~5.9.2"
9494
},
9595
"engines": {

boilerplate/plugins/withSplashScreen.ts

Lines changed: 0 additions & 69 deletions
This file was deleted.

docs/boilerplate/Boilerplate.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ your-project
3636
├── ignite
3737
│   └── templates
3838
├── ios
39-
├── plugins
40-
│   └── withSplashScreen.ts
4139
├── test
4240
│   ├── i18n.test.ts
4341
│   ├── mockFile.ts

docs/boilerplate/plugins/withSplashScreen.md

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)