feat(ui): test notification endpoints #16031
Conversation
| return | ||
| } | ||
|
|
||
| var token *influxdb.Authorization |
There was a problem hiding this comment.
This looks too hacky. @influxdata/compute-team has cleaned this up already for task. We should make sure the query proxy server can handle the context.
There was a problem hiding this comment.
@kelwang this is what is currently done in the /api/v2/query endpoint. I agree it's hacky and that we need a long term solution, but I'm not sure exactly what that looks like.
http/notification_endpoint.go
Outdated
| @@ -500,6 +637,7 @@ func (h *NotificationEndpointHandler) handlePutNotificationEndpoint(w http.Respo | |||
|
|
|||
| for _, fld := range edp.SecretFields() { | |||
| if fld.Value != nil { | |||
| fmt.Printf("hello: %v\n", *fld.Value) | |||
notification_endpoint.go
Outdated
| DeleteNotificationEndpoint(ctx context.Context, id ID) (flds []*SecretField, orgID ID, err error) | ||
|
|
||
| // TestNotificationEndpoint tests the an endpoints connection to a 3rd party service i.e. Slack, PagerDuty etc. | ||
| TestNotificationEndpoint(ctx context.Context, ne NotificationEndpoint, userID ID) error |
There was a problem hiding this comment.
A method prefix Test is like a reserved keyword to run test uniting in golang, thus might confuse people. If you can give an another name, it would be much preferred.
desa
force-pushed
the
feat/test-endpoints
branch
3 times, most recently
from
749b2e0 to
2eb1c50
Compare
feat(notEnd): add definition to swagger feat(wip): add endpoint test route feat(ui): add test endpoint button feat(wip): execute endpoint test query feat: implement test endpoint for slack feat: introduce http endopint test feat: implement http test endpoint with auth feat: add test PagerDuty endpoint fix: PagerDuty test query generation wip refactor: implement test endpoint for existing endpoints feat(endpoint-test): add error reporting feat(test-endpoint): hide testing on create fix: errors not caught test: remove only test: remove check for test button fix: thunk typings test: add testChannel to slack test: fix go and e2e fix: test and linting test: fix comment test test: fix test fix(notification/endpoint): add test channel to slack endpoint Co-Authored-By: Andrew Watkins <[email protected]>
desa
force-pushed
the
feat/test-endpoints
branch
from
2eb1c50 to
ff9fe6c
Compare
| saveButtonText: string | ||
| onSave: (endpoint: NotificationEndpoint) => void | ||
| onSave: (endpoint: NotificationEndpoint) => Promise<void> | ||
| onTest: (endpoint: NotificationEndpoint) => Promise<void> |
There was a problem hiding this comment.
Is there a reason why we've passed onTest all the way down here without using it?
|
|
||
| const resp = await api.postNotificationEndpointsTest({data}) | ||
|
|
||
| if (resp.status !== 204) { |
There was a problem hiding this comment.
It doesn't seem like testEndpoint ends being used in some instances, would it be more beneficial to dispatch a notification to the user?
| style={{width: 'auto', marginTop: '8px'}} | ||
| > | ||
| {errorMessage} | ||
| {message.text} |
There was a problem hiding this comment.
What if the text is undefined? Should we have a generic message to let the user know that something wrong happened?
Closes #14792