Skip to content

Commit f89fef0

Browse files
committed
fix: correct comments that framed preview as canonical over beta
beta is the canonical lifecycle term; preview is a backward-compat alias. Several comments had the relationship inverted.
1 parent 1ac38c4 commit f89fef0

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

internal/config/lifecycle.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func NormalizeLifecycle(lifecycle string) string {
4040
// Rules:
4141
//
4242
// experimental → must have -alpha.* prerelease
43-
// beta/preview → must have -alpha.*, -beta.*, or -rc.* prerelease
43+
// beta (or preview alias) → must have -alpha.*, -beta.*, or -rc.* prerelease
4444
// stable → must NOT have a prerelease tag
4545
// deprecated → any version allowed (warning emitted by caller)
4646
// sunset → blocked unless override is set
@@ -117,7 +117,7 @@ func LifecycleRequiresWarning(lifecycle string) bool {
117117
var lifecycleOrder = map[string]int{
118118
"experimental": 0,
119119
"preview": 1,
120-
"beta": 1, // alias — same rank as preview
120+
"beta": 1, // canonical; preview is a backward-compat alias
121121
"stable": 2,
122122
"deprecated": 3,
123123
"sunset": 4,

internal/config/version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ func ValidateVersionLine(version, line string) error {
242242
//
243243
// The lifecycle parameter is used to attach the correct prerelease tag:
244244
// - "experimental" → -alpha.1
245-
// - "preview"/"beta" → -beta.1
245+
// - "beta" → -beta.1 ("preview" accepted as alias)
246246
// - "stable" → no prerelease
247247
// - "deprecated" → no prerelease (but caller should warn)
248248
// - "sunset" → blocked

internal/config/version_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ func TestLifecyclePrerelease(t *testing.T) {
362362
assert.Equal(t, "alpha.1", lifecyclePrerelease("experimental", 1))
363363
assert.Equal(t, "alpha.3", lifecyclePrerelease("experimental", 3))
364364
assert.Equal(t, "beta.1", lifecyclePrerelease("preview", 1))
365-
assert.Equal(t, "beta.1", lifecyclePrerelease("beta", 1)) // alias for preview
365+
assert.Equal(t, "beta.1", lifecyclePrerelease("beta", 1)) // canonical form
366366
assert.Equal(t, "", lifecyclePrerelease("stable", 1))
367367
assert.Equal(t, "", lifecyclePrerelease("deprecated", 1))
368368
assert.Equal(t, "", lifecyclePrerelease("", 1))

0 commit comments

Comments
 (0)