fixed UTs

Author: unasra

internal/service/anycast/api_anycast_config_data_source_test.go

@@ -115,6 +115,7 @@ resource "bloxone_anycast_config" "test" {
 }
 data "bloxone_anycast_configs" "test" {
 	service = %q
+	name = bloxone_anycast_config.test.name
 	depends_on = [bloxone_anycast_config.test]
 }
 `, anycastIpAddress, name, service, service)

internal/service/anycast/api_anycast_config_resource_test.go

@@ -27,7 +27,7 @@ func TestAccAnycastConfigResource_basic(t *testing.T) {
 		Steps: []resource.TestStep{
 			// Create and Read
 			{
-				Config: testAccAnycastConfigResourceBasicConfig(anycastName, "DHCP", anycastIP),
+				Config: testAccAnycastConfigResourceBasicConfig(anycastName, "DNS", anycastIP),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckAnycastConfigResourceExists(context.Background(), resourceName, &v),
 					// Test Read Only fields
@@ -54,7 +54,7 @@ func TestAccAnycastConfigResource_disappears(t *testing.T) {
 		CheckDestroy:             testAccCheckAnycastConfigResourceDestroy(context.Background(), &v),
 		Steps: []resource.TestStep{
 			{
-				Config: testAccAnycastConfigResourceBasicConfig(anycastName, "DHCP", anycastIP),
+				Config: testAccAnycastConfigResourceBasicConfig(anycastName, "DNS", anycastIP),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckAnycastConfigResourceExists(context.Background(), resourceName, &v),
 					testAccCheckAnycastConfigResourceDisappears(context.Background(), &v),
@@ -78,7 +78,7 @@ func TestAccAnycastConfigResource_AnycastIpAddress(t *testing.T) {
 		Steps: []resource.TestStep{
 			// Create and Read
 			{
-				Config: testAccAnycastConfigResourceAnycastIpAddress(anycastIP1, anycastName, "DHCP"),
+				Config: testAccAnycastConfigResourceAnycastIpAddress(anycastIP1, anycastName, "DNS"),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckAnycastConfigResourceExists(context.Background(), resourceName, &v),
 					resource.TestCheckResourceAttr(resourceName, "name", anycastName),
@@ -87,7 +87,7 @@ func TestAccAnycastConfigResource_AnycastIpAddress(t *testing.T) {
 			},
 			// Update and Read
 			{
-				Config: testAccAnycastConfigResourceAnycastIpAddress(anycastIP2, anycastName, "DHCP"),
+				Config: testAccAnycastConfigResourceAnycastIpAddress(anycastIP2, anycastName, "DNS"),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckAnycastConfigResourceExists(context.Background(), resourceName, &v),
 					resource.TestCheckResourceAttr(resourceName, "name", anycastName),
@@ -174,18 +174,18 @@ func TestAccAnycastConfigResource_Service(t *testing.T) {
 		Steps: []resource.TestStep{
 			// Create and Read
 			{
-				Config: testAccAnycastConfigResourceService(anycastIP, anycastName, "DHCP"),
+				Config: testAccAnycastConfigResourceService(anycastIP, anycastName, "DFP"),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckAnycastConfigResourceExists(context.Background(), resourceName, &v),
-					resource.TestCheckResourceAttr(resourceName, "service", "DHCP"),
+					resource.TestCheckResourceAttr(resourceName, "service", "DFP"),
 				),
 			},
 			// Update and Read
 			{
-				Config: testAccAnycastConfigResourceService(anycastIP, anycastName, "DNS"),
+				Config: testAccAnycastConfigResourceService(anycastIP, anycastName, "NTP"),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckAnycastConfigResourceExists(context.Background(), resourceName, &v),
-					resource.TestCheckResourceAttr(resourceName, "service", "DNS"),
+					resource.TestCheckResourceAttr(resourceName, "service", "NTP"),
 				),
 			},
 			// Delete testing automatically occurs in TestCase

internal/service/anycast/model_proto_anycast_config.go

@@ -100,7 +100,7 @@ var ProtoAnycastConfigResourceSchemaAttributes = map[string]schema.Attribute{
 	},
 	"service": schema.StringAttribute{
 		Required:            true,
-		MarkdownDescription: "The type of the Service used in anycast configuration, supports (`dns`, `dhcp`, `dfp`).",
+		MarkdownDescription: "The type of the Service used in anycast configuration, supports (`dns`, `dfp`, `ntp`).",
 	},
 	"tags": schema.MapAttribute{
 		ElementType:         types.StringType,

internal/service/anycast/model_proto_bgp_config.go

@@ -88,6 +88,7 @@ var ProtoBgpConfigResourceSchemaAttributes = map[string]schema.Attribute{
 			Attributes: ProtoBgpNeighborResourceSchemaAttributes,
 		},
 		Optional:            true,
+		Computed:            true,
 		MarkdownDescription: `List of BgpNeighbor structs.`,
 	},
 	"preamble": schema.StringAttribute{

internal/service/anycast/model_proto_bgp_neighbor.go

@@ -64,6 +64,7 @@ var ProtoBgpNeighborResourceSchemaAttributes = map[string]schema.Attribute{
 	},
 	"ip_address": schema.StringAttribute{
 		Optional:            true,
+		Computed:            true,
 		MarkdownDescription: "IPv4 address of the BGP neighbor",
 	},
 	"max_hop_count": schema.Int64Attribute{

internal/service/anycast/model_proto_onprem_host.go

@@ -38,11 +38,13 @@ var ProtoOnpremHostResourceSchemaAttributes = map[string]schema.Attribute{
 			Attributes: ProtoAnycastConfigRefResourceSchemaAttributes,
 		},
 		Optional:            true,
+		Computed:            true,
 		MarkdownDescription: `Array of AnycastConfigRef structures, identifying the anycast configurations that this host is a member of.`,
 	},
 	"config_bgp": schema.SingleNestedAttribute{
 		Attributes:          ProtoBgpConfigResourceSchemaAttributes,
 		Optional:            true,
+		Computed:            true,
 		MarkdownDescription: `Struct BGP configuration; defines BGP configuration for one anycast-enabled on-prem host.`,
 	},
 	"config_ospf": schema.SingleNestedAttribute{

internal/service/fw/api_application_filter_data_source_test.go

@@ -46,7 +46,7 @@ func TestAccApplicationFiltersDataSource_TagFilters(t *testing.T) {
 		CheckDestroy:             testAccCheckApplicationFiltersDestroy(context.Background(), &v),
 		Steps: []resource.TestStep{
 			{
-				Config: testAccApplicationFiltersDataSourceConfigTagFilters(name, "Microsoft 365", "value1"),
+				Config: testAccApplicationFiltersDataSourceConfigTagFilters(name, "Microsoft 365", acctest.RandomName()),
 				Check: resource.ComposeTestCheckFunc(
 					append([]resource.TestCheckFunc{
 						testAccCheckApplicationFiltersExists(context.Background(), resourceName, &v),

internal/service/fw/api_category_filter_data_source_test.go

@@ -46,7 +46,7 @@ func TestAccCategoryFiltersDataSource_TagFilters(t *testing.T) {
 		CheckDestroy:             testAccCheckCategoryFiltersDestroy(context.Background(), &v),
 		Steps: []resource.TestStep{
 			{
-				Config: testAccCategoryFiltersDataSourceConfigTagFilters(name, "College", "value1"),
+				Config: testAccCategoryFiltersDataSourceConfigTagFilters(name, "College", acctest.RandomName()),
 				Check: resource.ComposeTestCheckFunc(
 					append([]resource.TestCheckFunc{
 						testAccCheckCategoryFiltersExists(context.Background(), resourceName, &v),

internal/service/fw/api_named_list_data_source_test.go

@@ -101,7 +101,7 @@ resource "bloxone_td_named_list" "test" {
 	]
 	type = "custom_list"
 	tags = {
-		display_name = "Terraform Example Named List"
+		display_name = %q
 	}
 }
 
@@ -110,5 +110,5 @@ data "bloxone_td_named_lists" "test" {
 		display_name = bloxone_td_named_list.test.tags.display_name
 	}
 }
-`, tagValue)
+`, name, tagValue)
 }