chore: Remove dependency on protoc, use the protox crate instead (#1034)

Author: romac

.github/workflows/coverage.yml

@@ -49,10 +49,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       # - name: Setup Node
       #   uses: actions/setup-node@v3
       #   with:

.github/workflows/docs.yml

@@ -41,10 +41,6 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Setup Rust toolchain
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:

.github/workflows/mbt.yml

@@ -40,10 +40,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Setup Node
         uses: actions/setup-node@v3
         with:

.github/workflows/publish.yml

@@ -13,10 +13,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Install Rust toolchain
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:

.github/workflows/rust.yml

@@ -43,10 +43,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
@@ -82,10 +78,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
@@ -131,10 +123,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Setup Rust toolchain
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
@@ -151,10 +139,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Setup Rust toolchain
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
@@ -198,10 +182,6 @@ jobs:
         with:
           toolchain: stable
           cache-workspaces: "code"
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Install cargo-msrv
         uses: taiki-e/install-action@v2
         with:
@@ -223,10 +203,6 @@ jobs:
         with:
           toolchain: stable
           cache-workspaces: "code"
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Install cargo-hack
         uses: taiki-e/install-action@v2
         with:

.github/workflows/semver.yml

@@ -41,10 +41,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
           toolchain: stable

CONTRIBUTING_CODE.md

@@ -25,7 +25,6 @@ This document provides guidelines and instructions to help you set up your devel
 To build and test Malachite, you need the following tools:
 
 - **Rust**: Install the latest stable Rust toolchain using [rustup](https://rustup.rs/)
-- **Protocol Buffers Compiler (protoc)**: Required for Protobuf message serialization
 - **Node.js**: Required for running [Quint](https://quint-lang.org)
 - **Quint**: A formal specification language used for our model-based tests
 - **cargo-nextest**: An improved test runner for Rust
@@ -40,25 +39,7 @@ To build and test Malachite, you need the following tools:
    curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
    ```
 
-2. **Install the Protocol Buffers Compiler**:
-
-   `protoc` is needed for compiling Protobuf definitions used in the test applications to Rust code.
-
-   For Ubuntu/Debian:
-
-   ```bash
-   sudo apt-get install protobuf-compiler
-   ```
-
-   For macOS:
-
-   ```bash
-   brew install protobuf
-   ```
-
-   Please ensure that the version of `protoc` is at least v29.0.
-
-3. **Install Node.js**: (only required for running model-based tests)
+2. **Install Node.js**: (only required for running model-based tests)
 
    Follow the instructions at [nodejs.org](https://nodejs.org/) or use a version manager:
 
@@ -69,19 +50,19 @@ To build and test Malachite, you need the following tools:
    nvm use 21
    ```
 
-4. **Install Quint**: (only required for running model-based tests)
+3. **Install Quint**: (only required for running model-based tests)
 
    ```bash
    npm install -g @informalsystems/quint
    ```
 
-5. **Install cargo-nextest**:
+4. **Install cargo-nextest**:
 
    ```bash
    cargo install cargo-nextest
    ```
 
-6. **Fork and clone the repository**:
+5. **Fork and clone the repository**:
 
    ```bash
    git clone https://github.com/USERNAME/malachite.git

code/Cargo.lock

@@ -147,6 +147,7 @@ prometheus-client  = "0.22"
 prost              = "0.13"
 prost-build        = "0.13"
 prost-types        = "0.13"
+protox             = "0.8.0"
 ractor             = { version = "0.14.6", default-features = false, features = ["async-trait", "tokio_runtime"] }
 rand               = { version = "0.8.5", features = ["std_rng", "small_rng"] }
 rand_chacha        = "0.3.1"

code/Cargo.toml

@@ -12,6 +12,7 @@ prost.workspace = true
 
 [build-dependencies]
 prost-build.workspace = true
+protox.workspace = true
 
 [lints]
 workspace = true

code/crates/starknet/p2p-proto/Cargo.toml

@@ -11,11 +11,13 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         println!("cargo:rerun-if-changed={proto}");
     }
 
+    let fds = protox::compile(protos, ["./proto"])?;
+
     let mut config = prost_build::Config::new();
     config.bytes(["."]);
     config.enable_type_names();
     config.default_package_filename("p2p");
-    config.compile_protos(protos, &["./proto"])?;
+    config.compile_fds(fds)?;
 
     Ok(())
 }

code/crates/starknet/p2p-proto/build.rs

@@ -49,6 +49,7 @@ tracing.workspace = true
 
 [build-dependencies]
 prost-build = { workspace = true }
+protox = { workspace = true }
 
 [lints]
 workspace = true