Take liquidity source addresses as an input instead of hardcoding

[hu55a1n1]

Summary

• currently hardcoded, but instead should be an input.
• prepares for getting the liquidity sources addresses directly from the contract

[hu55a1n1]

Some questions -

• Who can set/update liquidity sources? (potential for centralization? governance?)
• Should this be part of config?
• Does modifying liquidity sources create problems? (we probably want to tie them to epochs so it's not possible to modify liquidity sources for current epoch or something)

[ebuchman]

Some questions -

• Who can set/update liquidity sources? (potential for centralization? governance?)

Should be handled by the contract. Presumably initially it will only be some admin multisig, maybe over time becomes a governance thing. Though in principle we may want to enable a completely permissionless option so anyone can register a new liquidity source

• Should this be part of config?

the gramine config? could be but it can change over time. I was thinking rather it would be included as input with the obligations (so the input is the list of obligations and the list of liquidity sources)

• Does modifying liquidity sources create problems? (we probably want to tie them to epochs so it's not possible to modify liquidity sources for current epoch or something)

what do you mean modify them? like adding/removing them ? yes they need to be fixed per epoch .

ultimately, we may move away from having the enclave need to know about liquidity sources at all if we just encrypt them to a key with a publicly known private key then they can be decrypted by the smart contract or anyone as part of submission rather than the enclave needing to treat them separately.

but for now I think the easiest thing is probably to pass them in along with the obligations so we can remove them completely from any configs or binaries. for the sake of the demo we can just put the address in an an env var up front or in a file (ultimately the list of liquidity sources will be fetched from the contract and put in a file, similar to obligations).

[hu55a1n1]

the gramine config?

I meant contract/enclave config (which currently contains the light client params and epoch params). I basically wanted to know if liquidity sources remained constant for the lifetime of a contract or for an epoch - and your other comment answered my question ->

yes they need to be fixed per epoch .

[hu55a1n1]

https://github.com/informalsystems/bisenzone-cw-mvp/pull/32

[ebuchman]

Believe this is done in #52 or else is being taken care of by Dan's effort to make mtcs contract work with the overdraft and escrow contracts.

Reopen if it shouldnt be closed.