Skip to content
This repository was archived by the owner on Sep 6, 2023. It is now read-only.
This repository was archived by the owner on Sep 6, 2023. It is now read-only.

compile will sign if the signature files are present in the directory #114

Description

@zramsay

IMO this shouldn't be the default behaviour. It's neat that themis-contract sign brings in a copy of the signature into the pwd but it seems both redundant and detrimental. Does it really need it to be there in order to render the PDF? Then all these signatures images get committed (although they don't really need to?). Not sure if that's ideal from a general opsec point of view. Other issue that I've just run into is when updating / making a new contract from an existing one. Since those signature images are in that directory, running themis-contract compile ends up signing the PDF contract. My current workaround is to delete the counterparty's signature and have them sign+compile+commit+push the final PDF.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions