fix: 1. Configurable timeout: postAndReply now reads AGENT_REPLY_TIMEOUT_MS env var (default 30s), with improved error message showing the timeout value

  2. Double-logging fix: OrderContext.evaluate now returns Error [| e.Message |] instead of re-raising, so the error is logged once at the service level and wrapped into a Result — no second log entry from ApiImpl

Author: halcwb

src/Informedica.Agents.Lib/Agent.fs

@@ -278,18 +278,29 @@ module Agent =
 
     /// <summary>
     /// Posts a request to the agent and synchronously waits for a reply.
+    /// When DefaultTimeout is Timeout.Infinite, a configurable fallback timeout is used
+    /// (AGENT_REPLY_TIMEOUT_MS environment variable, default 30 000 ms).
     /// Throws if the reply times out.
     /// </summary>
     /// <param name="msg">The request message.</param>
     /// <param name="agent">The agent instance.</param>
     /// <returns>The reply value.</returns>
     let postAndReply msg (agent: Agent<_>) =
         if agent.DefaultTimeout = Timeout.Infinite then
+            let fallbackMs =
+                Environment.GetEnvironmentVariable("AGENT_REPLY_TIMEOUT_MS")
+                |> Option.ofObj
+                |> Option.bind (fun s ->
+                    match Int32.TryParse(s) with
+                    | true, v -> Some v
+                    | _ -> None
+                )
+                |> Option.defaultValue 30_000
             agent
-            |> tryPostAndReply 30_000 msg
+            |> tryPostAndReply fallbackMs msg
             |> function
                 | Some v -> v
-                | None -> failwith "Timed out waiting for reply"
+                | None -> failwith $"Timed out waiting for reply after {fallbackMs} ms"
         else
             agent.PostAndReply(fun replyChannel ->
                 msg, replyChannel

src/Informedica.GenPRES.Server/ServerApi.Services.fs

@@ -350,7 +350,7 @@ module OrderContext =
             with
             | e ->
                 writeErrorMessage $"errored:\n{e}"
-                raise e
+                Error [| e.Message |]
 
 
 module OrderPlan =