Skip to content

fix: wrong fantomas glob pattern#219

Merged
halcwb merged 2 commits intoinformedica:masterfrom
halcwb:master
Mar 24, 2026
Merged

fix: wrong fantomas glob pattern#219
halcwb merged 2 commits intoinformedica:masterfrom
halcwb:master

Conversation

@halcwb
Copy link
Collaborator

@halcwb halcwb commented Mar 24, 2026

Fix wrong fantomas setting resulting in a lot of unformatted files.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 24, 2026

Greptile Summary

This PR fixes two Fantomas configuration issues that were causing .fs files to be left unformatted across the repository.

  • .editorconfig: Corrects the glob section header from [*.{fs}] to [*.fs]. The curly-brace syntax ({...}) is intended for alternation groups (e.g., *.{fs,fsx}); using it with a single extension is non-standard and was causing Fantomas/EditorConfig parsers to not apply the formatting settings to .fs files.
  • .fantomasignore: Replaces two hard-coded .fsx file paths (Parallel.fsx, TypesSplit.fsx) with a single *.fsx wildcard, which correctly excludes all F# script files from formatting in a simpler and more maintainable way.

Confidence Score: 5/5

  • This PR is safe to merge — both changes are correct, minimal-scope config fixes with no logic or production code affected.
  • The changes are confined to two tooling config files. The .editorconfig fix is straightforwardly correct (removing superfluous curly braces from a single-extension glob), and the .fantomasignore simplification is logically equivalent to the previous two-path approach while being more comprehensive. No production code is touched.
  • No files require special attention.

Important Files Changed

Filename Overview
.editorconfig Fixes the EditorConfig glob pattern from [*.{fs}] to [*.fs]; the curly-brace syntax is for alternation groups and is superfluous with a single extension, causing Fantomas to miss the settings section.
.fantomasignore Replaces two hard-coded .fsx exclusion paths with a single *.fsx wildcard, correctly ignoring all F# script files from Fantomas formatting.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Source File] --> B{File extension?}
    B -- ".fsx" --> C[".fantomasignore: *.fsx"]
    C --> D[Skip formatting]
    B -- ".fs" --> E{In ignore list?}
    E -- "tests/.../Tests.fs" --> D
    E -- "Other .fs file" --> F[".editorconfig: [*.fs] section"]
    F --> G[Apply Fantomas settings\naligned brackets, aligned signatures,\nmax blank lines, etc.]
    G --> H[Format file]
Loading

Reviews (1): Last reviewed commit: "Merge branch 'master' into master" | Re-trigger Greptile

@halcwb halcwb merged commit c266ddf into informedica:master Mar 24, 2026
3 checks passed
github-actions bot pushed a commit to halcwb/GenPRES that referenced this pull request Mar 24, 2026
- Add FhirExpectoTests.fsx: Expecto test scaffolding for the FHIR bidirectional
  translation layer — 6 test suites covering FhirSystems constants, RouteMapping
  round-trips, PeriodUnitMapping round-trips, inferDoseType logic, and
  toFhirMedicationRequest / fromFhirMedicationRequest round-trips for all 11
  scenarios defined in ImplementationPlan.fsx
- Update CHANGELOG [Unreleased] with 24 March 2026 commits: FHIR implementation
  plan script (PR informedica#215), UI interactions improvements (PR informedica#216), fix select-all
  in treatment plan (PR informedica#217), Fantomas exclusions fix (PR informedica#218, informedica#219)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant