Skip to content

Fix fhir script#222

Merged
halcwb merged 5 commits intoinformedica:masterfrom
halcwb:fix-fhir-script
Mar 24, 2026
Merged

Fix fhir script#222
halcwb merged 5 commits intoinformedica:masterfrom
halcwb:fix-fhir-script

Conversation

@halcwb
Copy link
Collaborator

@halcwb halcwb commented Mar 24, 2026

This pull request introduces several significant improvements and fixes across the FHIR integration scripts, client UI, and build tooling. The main highlights are the addition of a comprehensive FHIR R4 integration prototype with supporting tests, enhancements to the client UI's drug interaction feature, and various build system fixes related to script formatting.

FHIR Integration and Testing:

  • Added ImplementationPlan.fsx, a detailed FHIR R4 integration prototype. This script defines types (FhirScenario, FhirMedicationRequest), implements bidirectional translation functions, maps interface specification scenarios 6.1–6.6, and documents the integration path with Hl7.Fhir.R4.
  • Introduced FhirExpectoTests.fsx, providing test scaffolding for the FHIR translation scenarios, including round-trip translation and coding system checks.
  • Added a reference to the HL7.Fhir.R4 NuGet package in load.fsx to enable FHIR R4 support in scripts.

Client UI Improvements:

  • Enhanced the drug interactions feature by deduplicating requests, improving retry state handling, and fixing unbounded concurrency issues.
  • Fixed the "Select All" functionality in the treatment plan table, improving performance from O(n²) to O(n) and ensuring correct row toggling.

Build and Tooling Fixes:

  • Excluded .fsx scripts from Fantomas auto-formatting and corrected the glob pattern to ensure scripts are properly ignored during formatting.

Repo Assist and others added 5 commits March 24, 2026 20:32
- Add FhirExpectoTests.fsx: Expecto test scaffolding for the FHIR bidirectional
  translation layer — 6 test suites covering FhirSystems constants, RouteMapping
  round-trips, PeriodUnitMapping round-trips, inferDoseType logic, and
  toFhirMedicationRequest / fromFhirMedicationRequest round-trips for all 11
  scenarios defined in ImplementationPlan.fsx
- Update CHANGELOG [Unreleased] with 24 March 2026 commits: FHIR implementation
  plan script (PR informedica#215), UI interactions improvements (PR informedica#216), fix select-all
  in treatment plan (PR informedica#217), Fantomas exclusions fix (PR informedica#218, informedica#219)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…og-24mar2026-3b81e2aba6289bec

[Repo Assist] docs/scripts(fhir): add FHIR test scaffolding and update CHANGELOG
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 24, 2026

Greptile Summary

This PR adds a FHIR R4 integration prototype and test scaffolding as .fsx scripts, updates load.fsx to reference the HL7.Fhir.R4 NuGet package, and adds corresponding CHANGELOG.md entries. The only production-visible change is the changelog update; all code changes live in .fsx script files.

  • CHANGELOG.md correctly documents the new FHIR scripts (ImplementationPlan.fsx, FhirExpectoTests.fsx), the UI drug-interaction improvements, and the Fantomas/glob build fix.
  • All three changed .fsx files (ImplementationPlan.fsx, FhirExpectoTests.fsx, load.fsx) are excluded from code review per project policy — they are temporary implementation scripts, not production source files.

Confidence Score: 5/5

  • Safe to merge — all code changes are in .fsx script files excluded from review, and the CHANGELOG.md update is accurate.
  • All three changed code files are .fsx scripts (excluded from review per project policy). The only reviewable file, CHANGELOG.md, contains straightforward and accurate documentation entries. No production source files were modified.
  • No files require special attention.

Important Files Changed

Filename Overview
CHANGELOG.md Adds changelog entries for FHIR script additions, UI improvements, and build fixes — straightforward documentation update.
src/Informedica.FHIR.Lib/Scripts/ImplementationPlan.fsx Excluded from review per custom instructions — .fsx script files are not production source code.
src/Informedica.FHIR.Lib/Scripts/FhirExpectoTests.fsx Excluded from review per custom instructions — .fsx script files are not production source code.
src/Informedica.FHIR.Lib/Scripts/load.fsx Excluded from review per custom instructions — .fsx script files are not production source code.

Sequence Diagram

sequenceDiagram
    participant App as Application
    participant Script as ImplementationPlan.fsx
    participant FHIR as Hl7.Fhir.R4

    App->>Script: Internal MedicationOrder
    Script->>Script: toFhirMedicationRequest()
    Script->>FHIR: FhirMedicationRequest scenarios 6.1 to 6.6
    FHIR-->>Script: FHIR R4 MedicationRequest resource
    Script->>Script: fromFhirMedicationRequest()
    Script-->>App: Internal MedicationOrder round-trip
    note over Script: FhirExpectoTests.fsx validates round-trip fidelity
Loading

Reviews (1): Last reviewed commit: "chore: Merge remote-tracking branch 'ups..." | Re-trigger Greptile

@halcwb halcwb merged commit 8ed5007 into informedica:master Mar 24, 2026
10 checks passed
@halcwb halcwb deleted the fix-fhir-script branch March 24, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant