chore: add more test-suites

Author: gerjanvangeest

packages/ui/components/menu/src/InteractiveListMixin.js

@@ -1,10 +1,9 @@
 /* eslint-disable max-classes-per-file */
 /* eslint-disable import/no-extraneous-dependencies */
 import { html, css, LitElement } from 'lit';
-import { SlotMixin, DisabledMixin } from '@lion/ui/core.js';
+import { SlotMixin, DisabledMixin, uuid } from '@lion/ui/core.js';
 import { dedupeMixin } from '@open-wc/dedupe-mixin';
 import { MoreButtonMenuMixin } from './MoreButtonMenuMixin.js';
-import { uuid } from './utils/uuid.js';
 import { isInView } from './utils/isInView.js';
 import {
   isDisabled,
@@ -167,7 +166,7 @@ const InteractiveListMixinImplementation = superclass =>
         multipleChoice: { type: Boolean, attribute: 'multiple-choice' },
         // TODO: align with name of open-ui
         selectionFollowsFocus: { type: Boolean, attribute: 'selection-follows-focus' },
-        // TODO: align with name of open-ui => "wrap" in focsugroup
+        // TODO: align with name of open-ui => "wrap" in focusgroup
         rotateKeyboardNavigation: { type: Boolean, attribute: 'rotate-keyboard-navigation' },
         // TODO: align with name of open-ui
         noPreselect: { type: Boolean, attribute: 'no-preselect' },
@@ -556,7 +555,7 @@ const InteractiveListMixinImplementation = superclass =>
       // having hideVisually as hide mechanism (opening on focus, closing on blur).
       // N.B. this._listNode has `display:flex`. This means we need to add `text-wrap: nowrap;`
       // to avoid elems going over two lines, or give them a max-height based on measuring the height of one item.
-      // 2. N.B. hideVisually needs to be implementd in OverlayController.
+      // 2. N.B. hideVisually needs to be implemented in OverlayController.
       // 3. when the more menu opens a next level, MultiLevelListMixin will be applied to the host as well.
       // That means it knows when a child menu is open. If _subListMap of one of the items is open, we should hide more menu like this:
       // https://jsfiddle.net/a4ocktfp/19/

packages/ui/components/menu/src/LionMenu.js

@@ -187,7 +187,7 @@ export class LionMenu extends MultiLevelListMixin(LitElement) {
     }
 
     if (!multiple) {
-      // Uncheck all
+      // Uncheck all within group
       listItemsWithinGroup.forEach(listItem => {
         setChecked(listItem, true);
       });

packages/ui/components/menu/src/LionTree.js

@@ -22,7 +22,7 @@ export class LionTree extends MultiLevelListMixin(LitElement) {
     super.updated(changedProperties);
 
     if (changedProperties.has('level')) {
-      if (this.level > 0) {
+      if (this.level > 1) {
         this._listNode.setAttribute('role', 'group');
       }
       this.__setAriaLevelForListItems();

packages/ui/components/menu/src/MultiLevelListMixin.js

@@ -37,8 +37,11 @@ const MultiLevelListMixinImplementation = superclass =>
      * @configure DisclosureMixin
      */
     get _invokerNode() {
-      // @ts-ignore - accessing static method and super property
-      return this.constructor._getFocusableInvokerEl(this.invokerNode) || super._invokerNode;
+      if (this.constructor._getFocusableInvokerEl && this.invokerNode) {
+        // @ts-ignore - accessing static method and super property
+        return this.constructor._getFocusableInvokerEl(this.invokerNode);
+      }
+      return super._invokerNode;
     }
 
     /**
@@ -84,6 +87,7 @@ const MultiLevelListMixinImplementation = superclass =>
       this.noPreselect = true;
       /**
        * @configure InteractiveListMixin
+       * @type {'activedescendant'|'roving-tabindex'|'tabbable-disclosure'}
        */
       this._activeMode = 'roving-tabindex';
       /**
@@ -257,7 +261,7 @@ const MultiLevelListMixinImplementation = superclass =>
       this._subListMap.forEach(subList => {
         subList.listItems.forEach(
           /** @param {LionItem|HTMLElement} item */ item => {
-            if (isChecked(item)) {
+            if (isChecked(item) && subList._invokerNode) {
               setChecked(subList._invokerNode);
             }
           },