Expected behavior
The _handleZIndex method should set z-index to '1' for local overlays during initialization when the content node doesn't have an explicit z-index.
This ensures local overlays appear on top of elements with no z-index that appear later in the DOM.
Actual Behavior
The z-index logic never executes because _handleZIndex checks for phase === 'setup', but this phase is never used anywhere in the codebase.
Code reference:
|
_handleZIndex({ phase }) { |
|
if (this.placementMode !== 'local') { |
|
return; |
|
} |
|
|
|
if (phase === 'setup') { |
|
const zIndexNumber = Number(getComputedStyle(this.contentNode).zIndex); |
|
if (zIndexNumber < 1 || Number.isNaN(zIndexNumber)) { |
|
this.contentNode.style.zIndex = '1'; |
|
} |
|
} |
|
} |
Suggested fix:
From if (phase === 'setup') to if (phase === 'init')
Additional context
This affects local overlays like tooltips when they don't have explicit z-index values set.
Expected behavior
The
_handleZIndexmethod should set z-index to '1' for local overlays during initialization when the content node doesn't have an explicit z-index.This ensures local overlays appear on top of elements with no z-index that appear later in the DOM.
Actual Behavior
The z-index logic never executes because
_handleZIndexchecks for phase === 'setup', but this phase is never used anywhere in the codebase.Code reference:
lion/packages/ui/components/overlays/src/OverlayController.js
Lines 680 to 691 in eb8b7bd
Suggested fix:
From
if (phase === 'setup')toif (phase === 'init')Additional context
This affects local overlays like tooltips when they don't have explicit z-index values set.